Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issue 2378143003: [profiler] Introduce Tracing CPU profiler V8 API. (Closed)

Created:
4 years, 2 months ago by alph
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[profiler] Introduce Tracing CPU profiler V8 API. Tracing CPU profiler allows V8 to automatically collect CPU profile when tracing is started with category v8.cpu_profile2 enabled. BUG=chromium:406277 Committed: https://crrev.com/e4e3650e8b6289bd0cd7500af6176dda81e8b585 Cr-Commit-Position: refs/heads/master@{#39855}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+69 lines, -0 lines) Patch
M BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M include/v8-profiler.h View 1 chunk +14 lines, -0 lines 0 comments Download
A src/profiler/tracing-cpu-profiler.h View 1 chunk +26 lines, -0 lines 0 comments Download
A src/profiler/tracing-cpu-profiler.cc View 1 chunk +25 lines, -0 lines 0 comments Download
M src/v8.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alph
Jochen, could you please take a look. Thanks.
4 years, 2 months ago (2016-09-29 08:29:27 UTC) #4
jochen (gone - plz use gerrit)
lgtm
4 years, 2 months ago (2016-09-29 08:57:48 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378143003/1
4 years, 2 months ago (2016-09-29 09:18:12 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 09:24:55 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 09:25:29 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e4e3650e8b6289bd0cd7500af6176dda81e8b585
Cr-Commit-Position: refs/heads/master@{#39855}

Powered by Google App Engine
This is Rietveld 408576698