Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: appengine/findit/model/crash/crash_analysis.py

Issue 2378133004: [Findit] Rerun if the regression range is different. (Closed)
Patch Set: Fix nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « appengine/findit/crash/test/findit_for_client_test.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/model/crash/crash_analysis.py
diff --git a/appengine/findit/model/crash/crash_analysis.py b/appengine/findit/model/crash/crash_analysis.py
index c5b63d7fdd9e8e52cda014d17d622b4115d5bc49..c2e453ebb4a03b8ec042ac9174dc8d360977ec51 100644
--- a/appengine/findit/model/crash/crash_analysis.py
+++ b/appengine/findit/model/crash/crash_analysis.py
@@ -31,6 +31,9 @@ class CrashAnalysis(ndb.Model):
# ID to differentiate different client.
client_id = ndb.StringProperty(indexed=False)
+ # Chrome regression range.
+ regression_range = ndb.JsonProperty(indexed=False)
+
################### Properties for the analysis progress. ###################
# The url path to the pipeline status page.
@@ -54,33 +57,32 @@ class CrashAnalysis(ndb.Model):
################### Properties for the analysis result. ###################
+ solution = ndb.StringProperty(indexed=True) # 'core', 'blame', etc.
+
# Analysis results.
result = ndb.JsonProperty(compressed=True, indexed=False)
- # Tags for query and monitoring.
+ # Flag to check whether there is a result.
has_regression_range = ndb.BooleanProperty(indexed=True)
found_suspects = ndb.BooleanProperty(indexed=True)
found_project = ndb.BooleanProperty(indexed=True)
found_components = ndb.BooleanProperty(indexed=True)
- solution = ndb.StringProperty(indexed=True) # 'core', 'blame', etc.
+ # Correct results.
+ culprit_regression_range = ndb.JsonProperty(indexed=False)
+ culprit_cls = ndb.JsonProperty(indexed=False)
+ culprit_components = ndb.JsonProperty(indexed=False)
+ culprit_project = ndb.StringProperty(indexed=False)
- # Triage results.
+ # Triage status - 'Untriaged', 'Incorrect', 'Correct', 'Unsure'.
regression_range_triage_status = ndb.IntegerProperty(
indexed=True, default=triage_status.UNTRIAGED)
- culprit_regression_range = ndb.JsonProperty(indexed=False)
-
suspected_cls_triage_status = ndb.IntegerProperty(
indexed=True, default=triage_status.UNTRIAGED)
- culprit_cls = ndb.JsonProperty(indexed=False)
-
- suspected_project_triage_status = ndb.IntegerProperty(
- indexed=True, default=triage_status.UNTRIAGED)
- culprit_project = ndb.StringProperty(indexed=False)
-
suspected_components_triage_status = ndb.IntegerProperty(
indexed=True, default=triage_status.UNTRIAGED)
- culprit_components = ndb.JsonProperty(indexed=False)
+ suspected_project_triage_status = ndb.IntegerProperty(
+ indexed=True, default=triage_status.UNTRIAGED)
triage_history = ndb.JsonProperty(indexed=False)
« no previous file with comments | « appengine/findit/crash/test/findit_for_client_test.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698