Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Unified Diff: appengine/findit/crash/test/crash_pipeline_test.py

Issue 2378133004: [Findit] Rerun if the regression range is different. (Closed)
Patch Set: Fix nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: appengine/findit/crash/test/crash_pipeline_test.py
diff --git a/appengine/findit/crash/test/crash_pipeline_test.py b/appengine/findit/crash/test/crash_pipeline_test.py
index 356d1531c834aedbe8e0425940669b06349e230c..634fb7972de839340f775a5dbce4114832189fdd 100644
--- a/appengine/findit/crash/test/crash_pipeline_test.py
+++ b/appengine/findit/crash/test/crash_pipeline_test.py
@@ -153,8 +153,8 @@ class CrashPipelineTest(CrashTestCase):
'process_type': 'browser',
}
stack_trace = 'frame1\nframe2\nframe3'
- chrome_version = '50.2500.0.0'
- historical_metadata = {'50.2500.0.0': 1.0}
+ chrome_version = '50.2500.0.1'
+ historical_metadata = None
mock_host = 'https://host.com'
self.mock(app_identity, 'get_default_version_hostname', lambda: mock_host)
@@ -189,7 +189,7 @@ class CrashPipelineTest(CrashTestCase):
self.assertEqual(1, len(analyzed_crashes))
self.assertEqual(
- (signature, platform, stack_trace, chrome_version, historical_metadata),
+ (signature, platform, stack_trace, chrome_version, None),
analyzed_crashes[0])
analysis = FracasCrashAnalysis.Get(crash_identifiers)
« no previous file with comments | « appengine/findit/crash/findit_for_client.py ('k') | appengine/findit/crash/test/findit_for_chromecrash_test.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698