Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2182)

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2378133004: [Findit] Rerun if the regression range is different. (Closed)
Patch Set: Fix nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | appengine/findit/crash/detect_regression_range.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: appengine/findit/crash/crash_pipeline.py
diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
index 4bf454b5be5887777f9fa0eb5ae3db2a32ac0789..6aa184692e2b6434388bc6de29f846a1b66963d1 100644
--- a/appengine/findit/crash/crash_pipeline.py
+++ b/appengine/findit/crash/crash_pipeline.py
@@ -108,10 +108,10 @@ def _NeedsNewAnalysis(
platform, stack_trace, customized_data):
analysis = findit_for_client.GetAnalysisForClient(crash_identifiers,
client_id)
- if analysis and not analysis.failed:
- # A new analysis is not needed if last one didn't complete or succeeded.
- # TODO(http://crbug.com/600535): re-analyze if stack trace or regression
- # range changed.
+ regression_range = findit_for_client.GetRegressionRange(client_id,
+ customized_data)
+ if (analysis and not analysis.failed and
+ regression_range == analysis.regression_range):
logging.info('The analysis of %s has already been done.',
repr(crash_identifiers))
return False
@@ -122,8 +122,8 @@ def _NeedsNewAnalysis(
client_id)
findit_for_client.ResetAnalysis(analysis, chrome_version, signature,
- client_id, platform, stack_trace,
- customized_data)
+ client_id, platform, stack_trace,
+ customized_data, regression_range)
return True
« no previous file with comments | « no previous file | appengine/findit/crash/detect_regression_range.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698