| Index: appengine/findit/crash/crash_pipeline.py
|
| diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py
|
| index 4bf454b5be5887777f9fa0eb5ae3db2a32ac0789..6aa184692e2b6434388bc6de29f846a1b66963d1 100644
|
| --- a/appengine/findit/crash/crash_pipeline.py
|
| +++ b/appengine/findit/crash/crash_pipeline.py
|
| @@ -108,10 +108,10 @@ def _NeedsNewAnalysis(
|
| platform, stack_trace, customized_data):
|
| analysis = findit_for_client.GetAnalysisForClient(crash_identifiers,
|
| client_id)
|
| - if analysis and not analysis.failed:
|
| - # A new analysis is not needed if last one didn't complete or succeeded.
|
| - # TODO(http://crbug.com/600535): re-analyze if stack trace or regression
|
| - # range changed.
|
| + regression_range = findit_for_client.GetRegressionRange(client_id,
|
| + customized_data)
|
| + if (analysis and not analysis.failed and
|
| + regression_range == analysis.regression_range):
|
| logging.info('The analysis of %s has already been done.',
|
| repr(crash_identifiers))
|
| return False
|
| @@ -122,8 +122,8 @@ def _NeedsNewAnalysis(
|
| client_id)
|
|
|
| findit_for_client.ResetAnalysis(analysis, chrome_version, signature,
|
| - client_id, platform, stack_trace,
|
| - customized_data)
|
| + client_id, platform, stack_trace,
|
| + customized_data, regression_range)
|
| return True
|
|
|
|
|
|
|