appengine/findit/crash/crash_pipeline.py - Issue 2378133004: [Findit] Rerun if the regression range is different.

Unified Diff: appengine/findit/crash/crash_pipeline.py

Issue 2378133004: [Findit] Rerun if the regression range is different. (Closed)

Patch Set: Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/crash/crash_pipeline.py

diff --git a/appengine/findit/crash/crash_pipeline.py b/appengine/findit/crash/crash_pipeline.py

index 4bf454b5be5887777f9fa0eb5ae3db2a32ac0789..dc49f8720261401bad8154ac7cbcc9bb7c7d8d95 100644

--- a/appengine/findit/crash/crash_pipeline.py

+++ b/appengine/findit/crash/crash_pipeline.py

@@ -108,10 +108,10 @@ def _NeedsNewAnalysis(

platform, stack_trace, customized_data):

analysis = findit_for_client.GetAnalysisForClient(crash_identifiers,

client_id)

- if analysis and not analysis.failed:

- # A new analysis is not needed if last one didn't complete or succeeded.

- # TODO(http://crbug.com/600535): re-analyze if stack trace or regression

- # range changed.

+ regression_range = findit_for_client.GetRegressionRange(client_id,

+ customized_data)

+ if (analysis and (regression_range == analysis.regression_range) and

stgao 2016/10/07 20:29:35 Should we also test regression_range is not empty?

Sharu Jiang 2016/10/07 22:05:03 For those with empty regressions, we can still fin

stgao 2016/10/07 22:26:04 What if both regression range are empty? Do we rea

+ not analysis.failed):

wrengr 2016/10/07 17:32:06 Does it make sense to check analysis.failed after

Sharu Jiang 2016/10/07 22:05:03 Done.

logging.info('The analysis of %s has already been done.',

repr(crash_identifiers))

return False

@@ -122,8 +122,8 @@ def _NeedsNewAnalysis(

client_id)

findit_for_client.ResetAnalysis(analysis, chrome_version, signature,

- client_id, platform, stack_trace,

- customized_data)

+ client_id, platform, stack_trace,

+ customized_data, regression_range)

return True