[Findit] Rerun if the regression range is different.

appengine/findit/crash/findit_for_client.py

 # Copyright 2016 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 """This module is interfacas between clients-specific code and core.
 
 Note, fracas and cracas are almost identical and fracas is an intermidiate
 state while transfering to cracas, so they can be handled in the same code path
 and can be referred to as chromecrash."""
 
 import copy
 import json
 import logging
 
 from google.appengine.ext import ndb
 
 from common import appengine_util
 from common import time_util
+from crash import detect_regression_range
 from crash import findit_for_chromecrash
+from crash.chromecrash_parser import ChromeCrashParser
 from crash.type_enums import CrashClient
 from model import analysis_status
 from model.crash.crash_config import CrashConfig
 from model.crash.fracas_crash_analysis import FracasCrashAnalysis
 from model.crash.cracas_crash_analysis import CracasCrashAnalysis
 
 # TODO(katesonia): Move this to fracas config.
 _FINDIT_FRACAS_FEEDBACK_URL_TEMPLATE = '%s/crash/fracas-result-feedback?key=%s'
 # TODO(katesonia): Move this to a common config in config page.
 _SUPPORTED_CLIENTS = [CrashClient.FRACAS, CrashClient.CRACAS]
@@ skipping 62 matching lines @@
   elif client_id == CrashClient.CRACAS:  # pragma: no cover.
     return CracasCrashAnalysis.Create(crash_identifiers)
   elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
     # TODO(katesonia): define ClusterfuzzCrashAnalysis.
     return None
 
   return None
 
 
 def ResetAnalysis(analysis, chrome_version, signature,
-                  client_id, platform, stack_trace, customized_data):
+                  client_id, platform, stack_trace, customized_data,
+                  regression_range):
   """Sets necessary info in the analysis for findit to run analysis."""
   analysis.Reset()
 
   # Set common properties.
   analysis.crashed_version = chrome_version
   analysis.stack_trace = stack_trace
   analysis.signature = signature
   analysis.platform = platform
   analysis.client_id = client_id
+  analysis.regression_range = regression_range
 
   if client_id == CrashClient.FRACAS or client_id == CrashClient.CRACAS:
     # Set customized properties.
     analysis.historical_metadata = customized_data.get('historical_metadata')
     analysis.channel = customized_data.get('channel')
   elif client_id == CrashClient.CLUSTERFUZZ:  # pragma: no cover.
     # TODO(katesonia): Set up clusterfuzz customized data.
     pass
 
   # Set analysis progress properties.
@@ skipping 19 matching lines @@
     # TODO(katesonia): Post process clusterfuzz analysis result if needed.
     pass
 
   return {
       'crash_identifiers': crash_identifiers,
       'client_id': analysis.client_id,
       'result': analysis_result,
   }
 
 
+def GetRegressionRange(client_id, customized_data):
+  if client_id == CrashClient.FRACAS or client_id == CrashClient.CRACAS:
+    return detect_regression_range.DetectRegressionRange(
+        customized_data.get('historical_metadata'))
+  elif client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
+    # TODO(katesonia): Get regression range from customized_data from
+    # clusterfuzz.
+    return None
+
+  return None
+
+
+def GetStacktraceParser(client_id):

[stgao, 2016/10/07 20:29:35]

This seems unused for now.

[Sharu Jiang, 2016/10/07 22:05:03]

Oops, should have deleted this.

+  if (client_id == CrashClient.FRACAS or
+      client_id == CrashClient.CRACAS):
+    return ChromeCrashParser()
+  elif client_id == CrashClient.CLUSTERFUZZ:  # pragma: no cover.
+    # TODO(katesonia): Implement findit_for_clusterfuzz.
+    return None
+
+  return None
+
+
 def FindCulprit(analysis):
-  result = {'found': False}
-  tags = {'found_suspects': False,
-          'has_regression_range': False}
-
   if (analysis.client_id == CrashClient.FRACAS or
       analysis.client_id == CrashClient.CRACAS):
-    result, tags = findit_for_chromecrash.FinditForChromeCrash().FindCulprit(
+    return findit_for_chromecrash.FinditForChromeCrash().FindCulprit(
         analysis.signature, analysis.platform, analysis.stack_trace,
-        analysis.crashed_version, analysis.historical_metadata)
-  elif analysis.client_id == CrashClient.CLUSTERFUZZ:  # pragma: no cover.
+        analysis.crashed_version, analysis.regression_range)
+  elif analysis.client_id == CrashClient.CLUSTERFUZZ: # pragma: no cover.
     # TODO(katesonia): Implement findit_for_clusterfuzz.
-    pass
+    return {}, {}
 
-  return result, tags
+  return {'found': False}, {'found_suspects': False,
+                            'has_regression_range': False}