Switch CFX_SAXReader to use std::stack.

Switch CFX_SAXReader to use std::stack.

Fix some nullptr errors.

BUG=pdfium:608
Committed: https://pdfium.googlesource.com/pdfium/+/aa69291d2c0f86259351a857acc3f9f073b56a55

[Lei Zhang, 2016-09-29 02:32:20]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 02:32:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 03:06:54]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 03:06:54]

Dry run: This issue passed the CQ dry run.

[Lei Zhang, 2016-09-29 03:10:19]

thestig@chromium.org changed reviewers:
+ tsepez@chromium.org, weili@chromium.org

[Lei Zhang, 2016-09-29 03:10:20]

Implementing one's own stack is hard.

[Tom Sepez, 2016-09-29 16:59:14]

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.cpp
File xfa/fde/xml/cfx_saxreader.cpp (right):

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:146: while (CFX_SAXItem* pItem = GetCurrentItem())
{
can we push a null item onto the stack?  Kinda wish this loop was "while stack
not empty"

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:163: CFX_SAXItem* pNew = new CFX_SAXItem;
nit: maybe ctor should take dwID as an argument since we immediately then set it
in all these cases?

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:715: if (pItem->m_eNode != CFX_SAXItem::Type::Tag)
nit: combine with above, also why does this one need to check for null pitem and
the others dont?

[Lei Zhang, 2016-09-29 18:52:20]

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.cpp
File xfa/fde/xml/cfx_saxreader.cpp (right):

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:146: while (CFX_SAXItem* pItem = GetCurrentItem())
{
On 2016/09/29 16:59:13, Tom Sepez wrote:
> can we push a null item onto the stack?  Kinda wish this loop was "while stack
> not empty"

No, but I'll switch to unique_ptr.

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:163: CFX_SAXItem* pNew = new CFX_SAXItem;
On 2016/09/29 16:59:14, Tom Sepez wrote:
> nit: maybe ctor should take dwID as an argument since we immediately then set
it
> in all these cases?

Done.

https://codereview.chromium.org/2378133003/diff/1/xfa/fde/xml/cfx_saxreader.c...
xfa/fde/xml/cfx_saxreader.cpp:715: if (pItem->m_eNode != CFX_SAXItem::Type::Tag)
On 2016/09/29 16:59:13, Tom Sepez wrote:
> nit: combine with above, also why does this one need to check for null pitem
and
> the others dont?

Done.

Because the input from the bug triggered a nullptr deref here.

[Lei Zhang, 2016-09-29 18:59:20]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 18:59:32]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 19:12:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 19:12:56]

Dry run: This issue passed the CQ dry run.

[Tom Sepez, 2016-09-29 20:25:37]

https://codereview.chromium.org/2378133003/diff/20001/xfa/fde/xml/cfx_saxread...
File xfa/fde/xml/cfx_saxreader.cpp (right):

https://codereview.chromium.org/2378133003/diff/20001/xfa/fde/xml/cfx_saxread...
xfa/fde/xml/cfx_saxreader.cpp:173: delete pItem;
How does this play with unique_ptr & pop?  Double free?

[Lei Zhang, 2016-09-29 20:29:58]

https://codereview.chromium.org/2378133003/diff/20001/xfa/fde/xml/cfx_saxread...
File xfa/fde/xml/cfx_saxreader.cpp (right):

https://codereview.chromium.org/2378133003/diff/20001/xfa/fde/xml/cfx_saxread...
xfa/fde/xml/cfx_saxreader.cpp:173: delete pItem;
On 2016/09/29 20:25:37, Tom Sepez wrote:
> How does this play with unique_ptr & pop?  Double free?

Of course. Simplified.

[Lei Zhang, 2016-09-29 20:30:06]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 20:30:16]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 21:03:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 21:03:52]

Dry run: Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)

[Lei Zhang, 2016-09-29 21:07:56]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 21:08:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 23:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 23:08:29]

Dry run: Try jobs failed on following builders:
  win on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  win_no_v8 on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)
  win_xfa_clang on master.tryserver.client.pdfium (JOB_TIMED_OUT, no build URL)

[Tom Sepez, 2016-09-30 20:24:39]

lgtm

[Lei Zhang, 2016-09-30 22:37:46]

The CQ bit was checked by thestig@chromium.org

[Lei Zhang, 2016-09-30 22:37:47]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/2378133003/#ps80001
(title: "rebase")

[commit-bot: I haz the power, 2016-09-30 22:37:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 22:49:26]

Description was changed from

==========
Switch CFX_SAXReader to use std::stack.

Fix some nullptr errors.

BUG=pdfium:608
==========

to

==========
Switch CFX_SAXReader to use std::stack.

Fix some nullptr errors.

BUG=pdfium:608

Committed:
https://pdfium.googlesource.com/pdfium/+/aa69291d2c0f86259351a857acc3f9f073b5...
==========

[commit-bot: I haz the power, 2016-09-30 22:49:27]

Committed patchset #5 (id:80001) as
https://pdfium.googlesource.com/pdfium/+/aa69291d2c0f86259351a857acc3f9f073b5...