Load offline page if reading list entry takes more than 1s to load.

ios/chrome/browser/reading_list/reading_list_model_impl.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ios/chrome/browser/reading_list/reading_list_model_impl.h"
 
 #include "ios/chrome/browser/reading_list/reading_list_model_storage.h"
 #include "url/gurl.h"
 
 ReadingListModelImpl::ReadingListModelImpl() : ReadingListModelImpl(NULL) {}
@@ skipping 36 matching lines @@
   return unread_size() && hasUnseen_;
 }
 
 void ReadingListModelImpl::ResetUnseenEntries() {
   DCHECK(loaded());
   hasUnseen_ = false;
   if (storageLayer_ && !IsPerformingBatchUpdates())
     storageLayer_->SavePersistentHasUnseen(false);
 }
 
-// Returns a specific entry.
-const ReadingListEntry& ReadingListModelImpl::GetUnreadEntryAtIndex(
+const ReadingListEntry* ReadingListModelImpl::GetUnreadEntryAtIndex(
     size_t index) const {
   DCHECK(loaded());
-  return unread_[index];
+  if (index >= unread_.size())
+    return nullptr;
+  return &unread_[index];
 }
 
-const ReadingListEntry& ReadingListModelImpl::GetReadEntryAtIndex(
+const ReadingListEntry* ReadingListModelImpl::GetReadEntryAtIndex(
     size_t index) const {
   DCHECK(loaded());
-  return read_[index];
+  if (index >= read_.size())
+    return nullptr;
+  return &read_[index];
+}
+
+const ReadingListEntry* ReadingListModelImpl::GetEntryFromURL(
+    const GURL& gurl) const {
+  auto it = std::find_if(

[gambard, 2016/10/03 09:04:45]

Use std::find with a entry created for the find.

+      read_.begin(), read_.end(),
+      [&gurl](const ReadingListEntry& entry) { return gurl == entry.URL(); });
+  if (it == read_.end()) {
+    it = std::find_if(
+        unread_.begin(), unread_.end(),
+        [&gurl](const ReadingListEntry& entry) { return gurl == entry.URL(); });
+    if (it == unread_.end())
+      return nullptr;
+  }
+  return &(*it);
 }
 
 bool ReadingListModelImpl::CallbackEntryURL(
     const GURL& url,
     base::Callback<void(const ReadingListEntry&)> callback) const {
   DCHECK(loaded());
   ReadingListEntry entry(url, std::string());
   auto resultUnread = std::find(unread_.begin(), unread_.end(), entry);
   if (resultUnread != unread_.end()) {
     callback.Run(*resultUnread);
@@ skipping 179 matching lines @@
 
 void ReadingListModelImpl::EndBatchUpdates() {
   ReadingListModel::EndBatchUpdates();
   if (IsPerformingBatchUpdates() || !storageLayer_) {
     return;
   }
   storageLayer_->SavePersistentUnreadList(unread_);
   storageLayer_->SavePersistentReadList(read_);
   storageLayer_->SavePersistentHasUnseen(hasUnseen_);
 }