Issue 23781008: Prevent crash in DocumentLoader::dataReceived

Issue 23781008: Prevent crash in DocumentLoader::dataReceived (Closed)

Created:
7 years, 3 months ago by pdr.

Modified:
7 years, 3 months ago

Reviewers:
Nate Chapin, abarth-chromium

CC:
blink-reviews, gavinp+loader_chromium.org

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Prevent crash in DocumentLoader::dataReceived This patch prevents a crash in DocumentLoader::dataReceived where the frame can be destructed in the middle of dataReceived. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157866

Patch Set 1 #

Patch Set 2 : Remove bits of 23781008 that snuck into this patch #

Patch Set 3 : Deflakify test #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+19 lines, -0 lines)			Patch
A	LayoutTests/fast/parser/resources/remove-parent.xhtml	View		1 chunk	+5 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/parser/xhtml-synchronous-detach-crash.html	View	1 2	1 chunk	+14 lines, -0 lines	0 comments	Download
A +	LayoutTests/fast/parser/xhtml-synchronous-detach-crash-expected.txt	View	1 2	0 chunks	+-1 lines, --1 lines	0 comments	Download
M	Source/core/loader/DocumentLoader.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (0 generated)

Expand Messages | Collapse Messages

pdr.

On 2013/09/16 22:25:58, Nate Chapin wrote: > LGTM > > Bug number? No bug, this ...

7 years, 3 months ago (2013-09-16 22:34:19 UTC) #3

Nate Chapin

On 2013/09/16 22:34:19, pdr wrote: > On 2013/09/16 22:25:58, Nate Chapin wrote: > > LGTM ...

7 years, 3 months ago (2013-09-16 22:35:16 UTC) #5

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pdr@chromium.org/23781008/7001

7 years, 3 months ago (2013-09-16 22:35:33 UTC) #6

Message was sent while issue was closed.

Change committed as 157866

Expand Messages | Collapse Messages