Replace deprecated version of SetWithoutPathExpansion()

Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value) used std::move()
in RegisterBackgroundContents of background_contents_service and MergeDataAndStartSyncing and ProcessSyncChanges of supervised_user_sync_service.cc

BUG=650082
Committed: https://crrev.com/5037fa115e066741053b02372832295fd7851631
Cr-Commit-Position: refs/heads/master@{#424378}

[pwang, 2016-09-28 14:24:08]

Description was changed from

==========
Deprecated version of SetWithoutPathExpansion

BUG=650082
==========

to

==========
Deprecated version of SetWithoutPathExpansion

BUG=650082
==========

[pwang, 2016-09-28 14:24:08]

pwangkk@gmail.com changed reviewers:
+ jinho.bang@samsung.com, simonhong@chromium.org

[pwang, 2016-09-28 14:29:01]

SetWithoutPathExpansion(..., Value* in_value) changed
to the SetWithoutPathExpansion(..., std::unique_ptr<Value> in_value)

[zino, 2016-09-28 14:47:37]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 14:47:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 14:58:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:58:14]

Dry run: Try jobs failed on following builders:
  android_compile_dbg on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_comp...)

[zino, 2016-09-28 16:11:15]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 16:11:36]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 16:21:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 16:21:44]

Dry run: Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[zino, 2016-09-29 09:51:58]

The CQ bit was checked by jinho.bang@samsung.com to run a CQ dry run

[commit-bot: I haz the power, 2016-09-29 09:52:11]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-29 11:05:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-29 11:05:10]

Dry run: This issue passed the CQ dry run.

[pwang, 2016-09-29 11:32:22]

pwangkk@gmail.com changed reviewers:
+ atwilson@chromium.org, bauerb@chromium.org

[pwang, 2016-09-29 11:46:22]

Hello, I'm newbie developer in the chromium project.

https://cs.chromium.org/chromium/src/base/values.h?q=setwithout&sq=package:ch...

I try to change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

PTAL

[Bernhard Bauer, 2016-09-30 09:09:23]

The patch looks good, but can you update the description? "Replace deprecated
version of SetWithoutPathExpansion()" would already be an improvement, as it
mentions _what_ the patch is doing; ideally you'd also mention where you make
that change (in background mode and supervised user code).

In general, http://chris.beams.io/posts/git-commit/ is a very good explanation
of how to write commit messages.

[pwang, 2016-09-30 14:11:11]

Description was changed from

==========
Deprecated version of SetWithoutPathExpansion

BUG=650082
==========

to

==========
Replace deprecated
version of SetWithoutPathExpansion()

BUG=650082
==========

[pwang, 2016-09-30 14:11:28]

Description was changed from

==========
Replace deprecated
version of SetWithoutPathExpansion()

BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

BUG=650082
==========

[pwang, 2016-09-30 14:22:44]

Description was changed from

==========
Replace deprecated version of SetWithoutPathExpansion()

BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

BUG=650082
==========

[pwang, 2016-09-30 14:26:13]

Description was changed from

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)


BUG=650082
==========

[pwang, 2016-09-30 14:56:52]

Description was changed from

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)


BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and In order to use
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value) used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc



BUG=650082
==========

[pwang, 2016-09-30 14:57:21]

Description was changed from

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and In order to use
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value) used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc



BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)
used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc



BUG=650082
==========

[pwang, 2016-09-30 15:01:20]

pwangkk@gmail.com changed reviewers:
- atwilson@chromium.org, jinho.bang@samsung.com, simonhong@chromium.org

[pwang, 2016-09-30 15:01:21]

Thank you for your advice
I thought you are right so I've just changed things that you mentioned.
if you find wrong something, please notice me again.

[Bernhard Bauer, 2016-09-30 15:20:11]

On 2016/09/30 15:01:21, pwang wrote:
> Thank you for your advice
> I thought you are right so I've just changed things that you mentioned.
> if you find wrong something, please notice me again.

LGTM, thanks!

[pwang, 2016-09-30 16:19:45]

pwangkk@gmail.com changed reviewers:
+ jinho.bang@samsung.com, simonhong@chromium.org

[pwang, 2016-09-30 16:33:49]

The CQ bit was checked by pwangkk@gmail.com

[commit-bot: I haz the power, 2016-09-30 16:34:19]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 16:44:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 16:44:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pwang, 2016-09-30 16:52:20]

pwangkk@gmail.com changed reviewers:
+ atwilson@chromium.org

[pwang, 2016-09-30 16:53:43]

pwangkk@gmail.com changed reviewers:
- bauerb@chromium.org, jinho.bang@samsung.com, simonhong@chromium.org

[pwang, 2016-09-30 16:53:45]

PTAL

[pwang, 2016-09-30 16:55:29]

pwangkk@gmail.com changed reviewers:
+ jinho.bang@samsung.com, simonhong@chromium.org

[pwang, 2016-10-11 05:53:56]

pwangkk@gmail.com changed reviewers:
+ bauerb@chromium.org
- atwilson@chromium.org, jinho.bang@samsung.com, simonhong@chromium.org

[pwang, 2016-10-11 05:54:38]

The CQ bit was checked by pwangkk@gmail.com

[pwang, 2016-10-11 05:54:38]

The patchset sent to the CQ was uploaded after l-g-t-m from bauerb@chromium.org
Link to the patchset: https://codereview.chromium.org/2378083002/#ps60001
(title: "restored background directory file")

[commit-bot: I haz the power, 2016-10-11 05:54:57]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwang, 2016-10-11 05:55:29]

The CQ bit was unchecked by pwangkk@gmail.com

[pwang, 2016-10-11 05:58:42]

The CQ bit was checked by pwangkk@gmail.com

[commit-bot: I haz the power, 2016-10-11 05:59:00]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pwang, 2016-10-11 05:59:51]

pwangkk@gmail.com changed reviewers:
+ jinho.bang@samsung.com

[commit-bot: I haz the power, 2016-10-11 06:29:51]

Description was changed from

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)
used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc



BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)
used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc



BUG=650082
==========

[commit-bot: I haz the power, 2016-10-11 06:29:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-11 06:31:23]

Description was changed from

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)
used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc



BUG=650082
==========

to

==========
Replace deprecated version of SetWithoutPathExpansion()

change SetWithoutPathExpansion(...,Value* in_value) to
SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)

I changed to std::unique_ptr<base::DictionaryValue> and
In order to use SetWithoutPathExpansion(...,std::unique_ptr<Value> in_value)
used std::move()
in RegisterBackgroundContents of background_contents_service and
MergeDataAndStartSyncing and ProcessSyncChanges of
supervised_user_sync_service.cc

BUG=650082

Committed: https://crrev.com/5037fa115e066741053b02372832295fd7851631
Cr-Commit-Position: refs/heads/master@{#424378}
==========

[commit-bot: I haz the power, 2016-10-11 06:31:24]

Patchset 4 (id:??) landed as
https://crrev.com/5037fa115e066741053b02372832295fd7851631
Cr-Commit-Position: refs/heads/master@{#424378}