Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(860)

Issue 2378073002: Reland of ServiceWorker: Implement StartWorker by using mojo (Closed)

Created:
4 years, 2 months ago by jwd
Modified:
4 years, 2 months ago
CC:
Aaron Boodman, abarth-chromium, ben+mojo_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin (slow to review), darin-cc_chromium.org, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, mlamouri+watch-content_chromium.org, nhiroki, qsr+mojo_chromium.org, serviceworker-reviews, tzik, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland of ServiceWorker: Implement StartWorker by using mojo (patchset #1 id:1 of https://codereview.chromium.org/2381513002/ ) Reason for revert: Did not compile. Original issue's description: > Revert of ServiceWorker: Implement StartWorker by using mojo (patchset #22 id:500001 of https://codereview.chromium.org/2227593002/ ) > > Reason for revert: > Looks like this is causing failures on webkit builders https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Leak > > Original issue's description: > > ServiceWorker: Implement StartWorker by using mojo > > > > This patch is the first step of mojofication on the service worker. > > In this patch, EWInstance will send StartWorker IPC using mojo. The endpoint on > > the renderer process is EWInstanceClient which is corresponding to one > > EWInstance. In future, this enables us to remove EWDispatcher, but > > EWInstanceClient has reference to EWDispatcher for now. > > > > BUG=629701 > > > > Committed: https://crrev.com/5db8eb672a52385059d4d188e27d7a7f0a5dd29d > > Cr-Commit-Position: refs/heads/master@{#421427} > > TBR=horo@chromium.org,mek@chromium.org,dcheng@chromium.org,falken@chromium.org,avi@chromium.org,shimazu@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=629701 > > Committed: https://crrev.com/295acb8b68aa9b7084f5e35bad5aef9b427d9e03 > Cr-Commit-Position: refs/heads/master@{#421509} TBR=horo@chromium.org,mek@chromium.org,dcheng@chromium.org,falken@chromium.org,avi@chromium.org,shimazu@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=629701 Committed: https://crrev.com/5c803109f843d2e3af0bf7402d0fb097e5195d06 Cr-Commit-Position: refs/heads/master@{#421513}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+581 lines, -143 lines) Patch
M content/browser/renderer_host/render_process_host_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 6 chunks +10 lines, -3 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 14 chunks +57 lines, -28 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 20 chunks +62 lines, -23 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 5 chunks +11 lines, -6 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 2 chunks +17 lines, -2 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 7 chunks +45 lines, -5 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 5 chunks +78 lines, -11 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M content/common/BUILD.gn View 2 chunks +3 lines, -0 lines 0 comments Download
A content/common/service_worker/embedded_worker.mojom View 1 chunk +16 lines, -0 lines 0 comments Download
A content/common/service_worker/embedded_worker.typemap View 1 chunk +10 lines, -0 lines 0 comments Download
M content/common/service_worker/embedded_worker_messages.h View 3 chunks +13 lines, -12 lines 0 comments Download
A content/common/service_worker/embedded_worker_start_params.h View 1 chunk +30 lines, -0 lines 0 comments Download
A content/common/service_worker/embedded_worker_start_params.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_utils.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/common/service_worker/service_worker_utils.cc View 2 chunks +7 lines, -0 lines 0 comments Download
M content/common/typemaps.gni View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/app/mojo/content_renderer_manifest.json View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/public/common/content_switches.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M content/renderer/BUILD.gn View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/render_thread_impl.cc View 2 chunks +6 lines, -2 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.h View 2 chunks +36 lines, -3 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 4 chunks +47 lines, -44 lines 0 comments Download
A content/renderer/service_worker/embedded_worker_instance_client_impl.h View 1 chunk +38 lines, -0 lines 0 comments Download
A content/renderer/service_worker/embedded_worker_instance_client_impl.cc View 1 chunk +62 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/VirtualTestSuites View 1 chunk +5 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/virtual/mojo-service-worker/http/tests/serviceworker/README.txt View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
jwd
Created Reland of ServiceWorker: Implement StartWorker by using mojo
4 years, 2 months ago (2016-09-28 14:14:35 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378073002/1
4 years, 2 months ago (2016-09-28 14:14:46 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 14:16:03 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5c803109f843d2e3af0bf7402d0fb097e5195d06 Cr-Commit-Position: refs/heads/master@{#421513}
4 years, 2 months ago (2016-09-28 14:17:56 UTC) #6
jwd
4 years, 2 months ago (2016-09-28 14:19:44 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2375943002/ by jwd@chromium.org.

The reason for reverting is: Found the compile issue..

Powered by Google App Engine
This is Rietveld 408576698