Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Issue 2378053003: PPC/s390: [heap] New heuristics for incremental marking step size. (Closed)

Created:
4 years, 2 months ago by Kelvin Li
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC/s390: [heap] New heuristics for incremental marking step size. Port: 1beb89f24cb01663843a7519921e7caf0910c760 This patch simplifies code for speeding up marking and removes write barrier counter. The step size is now computed based in two parts: - bytes to mark in order to keep up with allocation, - bytes to mark in order to make progress. R=mvstanton@chromium.org, joransiu@ca.ibm.com, jyan@ca.ibm.com, michael_dawson@ca.ibm.com, mbrandy@us.ibm.com, bjaideep@ca.ibm.com BUG= Committed: https://crrev.com/429e93bd6be95a7788155dca9901c839b353163e Cr-Commit-Position: refs/heads/master@{#39876}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -25 lines) Patch
M src/ppc/code-stubs-ppc.cc View 1 chunk +0 lines, -13 lines 0 comments Download
M src/s390/code-stubs-s390.cc View 1 chunk +0 lines, -12 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
Kelvin Li
4 years, 2 months ago (2016-09-29 13:24:56 UTC) #1
JaideepBajwa
lgtm
4 years, 2 months ago (2016-09-29 14:00:36 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378053003/1
4 years, 2 months ago (2016-09-29 14:02:20 UTC) #4
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started by full ...
4 years, 2 months ago (2016-09-29 14:02:22 UTC) #6
john.yan
lgtm
4 years, 2 months ago (2016-09-29 14:06:35 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2378053003/1
4 years, 2 months ago (2016-09-29 14:27:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-29 15:15:42 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-29 15:16:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/429e93bd6be95a7788155dca9901c839b353163e
Cr-Commit-Position: refs/heads/master@{#39876}

Powered by Google App Engine
This is Rietveld 408576698