Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5466)

Unified Diff: chrome/browser/chromeos/login/users/affiliation_unittest.cc

Issue 2378043002: Remove IsUserAffiliated()'s obsolete dependency on enrollment domain. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/login/users/affiliation_unittest.cc
diff --git a/chrome/browser/chromeos/login/users/affiliation_unittest.cc b/chrome/browser/chromeos/login/users/affiliation_unittest.cc
index 1ab758eaec82ce2bfe48d8182553db6b358916d7..21dfcf96d09a746d4daa13662a3061644681162a 100644
--- a/chrome/browser/chromeos/login/users/affiliation_unittest.cc
+++ b/chrome/browser/chromeos/login/users/affiliation_unittest.cc
@@ -78,31 +78,22 @@ TEST(AffiliationTest, Generic) {
AffiliationIDSet user_ids; // User affiliation IDs.
AffiliationIDSet device_ids; // Device affiliation IDs.
- EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "", ""));
peletskyi 2016/09/28 14:08:53 I'd leave this test case of the not valid email.
Thiemo Nagel 2016/09/28 14:13:45 I've just moved them to the bottom to also check t
+ // Empty affiliation IDs.
+ EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user@managed.com"));
- EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user", ""));
peletskyi 2016/09/28 14:08:53 And this
Thiemo Nagel 2016/09/28 14:13:45 see above
-
- // Not valid email.
- EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user", "user"));
-
- EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user@notmanaged.com",
- "managed.com"));
-
- EXPECT_TRUE(IsUserAffiliated(user_ids, device_ids, "user@managed.com",
- "managed.com"));
-
- user_ids.insert("aaaa"); // Only user affiliation IDs present. Compare email.
- EXPECT_TRUE(IsUserAffiliated(user_ids, device_ids, "user@managed.com",
- "managed.com"));
+ user_ids.insert("aaaa"); // Only user affiliation IDs present.
+ EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user@managed.com"));
device_ids.insert("bbbb"); // Device and user IDs do not overlap.
- EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user@managed.com",
- "managed.com"));
+ EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user@managed.com"));
user_ids.insert("cccc"); // Device and user IDs do overlap.
device_ids.insert("cccc");
- EXPECT_TRUE(IsUserAffiliated(user_ids, device_ids, "user@notmanaged.com",
- "managed.com"));
+ EXPECT_TRUE(IsUserAffiliated(user_ids, device_ids, "user@managed.com"));
+
+ // Invalid email overrides match of affiliation IDs.
+ EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, ""));
+ EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user"));
}
} // namespace chromeos
« no previous file with comments | « chrome/browser/chromeos/login/users/affiliation.cc ('k') | chrome/browser/chromeos/login/users/chrome_user_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698