Remove IsUserAffiliated()'s obsolete dependency on enrollment domain.

Remove IsUserAffiliated()'s obsolete dependency on enrollment domain.

The fallback isn't needed anymore because DM server has been updated to
send affiliation ids.

BUG=515476
TEST=updated unittest

Committed: https://crrev.com/e682d3b4bf05280bf2d314b0f8029bd14413fc35
Cr-Commit-Position: refs/heads/master@{#423832}

[Thiemo Nagel, 2016-09-28 13:51:24]

The CQ bit was checked by tnagel@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 13:51:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-09-28 13:53:12]

tnagel@chromium.org changed reviewers:
+ peletskyi@chromium.org

[Thiemo Nagel, 2016-09-28 13:53:12]

Hi Sasha,

could you ptal since you've last touched that code?

Thank you!
Thiemo

[Thiemo Nagel, 2016-09-28 13:54:20]

tnagel@chromium.org changed reviewers:
+ alemate@chromium.org

[Thiemo Nagel, 2016-09-28 13:54:21]

Hi Alexander,

could you please to an OWNERS review?

Thank you!
Thiemo

[peletskyi, 2016-09-28 14:08:53]

https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/affiliation_unittest.cc (left):

https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/affiliation_unittest.cc:81:
EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "", ""));
I'd leave this test case of the not valid email.

https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/affiliation_unittest.cc:83:
EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user", ""));
And this

[Thiemo Nagel, 2016-09-28 14:13:46]

https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
File chrome/browser/chromeos/login/users/affiliation_unittest.cc (left):

https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/affiliation_unittest.cc:81:
EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "", ""));
On 2016/09/28 14:08:53, peletskyi wrote:
> I'd leave this test case of the not valid email.

I've just moved them to the bottom to also check that invalid email overrides id
match.

https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
chrome/browser/chromeos/login/users/affiliation_unittest.cc:83:
EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user", ""));
On 2016/09/28 14:08:53, peletskyi wrote:
> And this

see above

[commit-bot: I haz the power, 2016-09-28 14:14:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 14:14:35]

Dry run: This issue passed the CQ dry run.

[peletskyi, 2016-09-28 15:12:20]

On 2016/09/28 14:13:46, Thiemo Nagel (slow) wrote:
>
https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
> File chrome/browser/chromeos/login/users/affiliation_unittest.cc (left):
> 
>
https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/users/affiliation_unittest.cc:81:
> EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "", ""));
> On 2016/09/28 14:08:53, peletskyi wrote:
> > I'd leave this test case of the not valid email.
> 
> I've just moved them to the bottom to also check that invalid email overrides
id
> match.
> 
>
https://codereview.chromium.org/2378043002/diff/1/chrome/browser/chromeos/log...
> chrome/browser/chromeos/login/users/affiliation_unittest.cc:83:
> EXPECT_FALSE(IsUserAffiliated(user_ids, device_ids, "user", ""));
> On 2016/09/28 14:08:53, peletskyi wrote:
> > And this
> 
> see above

True, LGTM

[Thiemo Nagel, 2016-10-06 12:09:44]

Alexander, friendly ping...

[Alexander Alekseev, 2016-10-06 21:05:41]

lgtm

Sorry for the late response.

[Thiemo Nagel, 2016-10-07 10:09:40]

The CQ bit was checked by tnagel@chromium.org

[commit-bot: I haz the power, 2016-10-07 10:09:50]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Thiemo Nagel, 2016-10-07 10:09:58]

On 2016/10/06 21:05:41, Alexander Alekseev wrote:
> lgtm
> 
> Sorry for the late response.

Np, thank you!

[commit-bot: I haz the power, 2016-10-07 10:35:43]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-10-07 10:37:16]

Description was changed from

==========
Remove IsUserAffiliated()'s obsolete dependency on enrollment domain.

The fallback isn't needed anymore because DM server has been updated to
send affiliation ids.

BUG=515476
TEST=updated unittest
==========

to

==========
Remove IsUserAffiliated()'s obsolete dependency on enrollment domain.

The fallback isn't needed anymore because DM server has been updated to
send affiliation ids.

BUG=515476
TEST=updated unittest

Committed: https://crrev.com/e682d3b4bf05280bf2d314b0f8029bd14413fc35
Cr-Commit-Position: refs/heads/master@{#423832}
==========

[commit-bot: I haz the power, 2016-10-07 10:37:17]

Patchset 1 (id:??) landed as
https://crrev.com/e682d3b4bf05280bf2d314b0f8029bd14413fc35
Cr-Commit-Position: refs/heads/master@{#423832}