Site Settings Desktop: Make sure AllSites list doesn't show icon/menu per site.

chrome/browser/resources/settings/site_settings/site_list.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Enumeration mapping all possible controlled-by values for exceptions to
  * icons.
  * @enum {string}
  */
 var iconControlledBy = {
@@ skipping 112 matching lines @@
         this.onIncognitoStatusChanged_.bind(this));
   },
 
   /**
    * Called when a site changes permission.
    * @param {string} category The category of the site that changed.
    * @param {string} site The site that changed.
    * @private
    */
   siteWithinCategoryChanged_: function(category, site) {
-    if (category == this.category || this.category == settings.ALL_SITES)
+    if (category == this.category || this.allSites)
       this.configureWidget_();
   },
 
   onIncognitoStatusChanged_: function(incognitoEnabled) {
     // A change notification is not sent for each site that is deleted during
     // incognito profile destruction. Therefore, we reconfigure the list when
     // the incognito profile is destroyed, except for SESSION_ONLY, which won't
     // have any incognito exceptions.
     if (this.categorySubtype == settings.PermissionValues.SESSION_ONLY)
       return;
@@ skipping 54 matching lines @@
   },
 
   /**
    * Returns which icon, if any, should represent the fact that this exception
    * is controlled.
    * @param {!SiteException} item The item from the list we're computing the
    *    icon for.
    * @return {string} The icon to show (or blank, if none).
    */
   computeIconControlledBy_: function(item) {
+    if (this.allSites)
+      return '';
     return iconControlledBy[item.source] || '';
   },
 
   /**
    * @param {string} source Where the setting came from.
    * @return {boolean}
    * @private
    */
   shouldShowMenu_: function(source) {
     return !(this.isExceptionControlled_(source) || this.allSites);
@@ skipping 95 matching lines @@
   /**
    * Appends to |list| the sites for a given category and subtype.
    * @param {!Array<SiteException>} sites The site list to add to.
    * @param {!Array<SiteException>} exceptionList List of sites (exceptions) to
    *     add.
    * @return {!Array<SiteException>} The list of sites.
    * @private
    */
   appendSiteList_: function(sites, exceptionList) {
     for (var i = 0; i < exceptionList.length; ++i) {
-      if (this.category != settings.ALL_SITES) {
+      if (!this.allSites) {
         if (exceptionList[i].setting == settings.PermissionValues.DEFAULT)
           continue;
 
         if (exceptionList[i].setting != this.categorySubtype)
           continue;
       }
 
       sites.push(exceptionList[i]);
     }
     return sites;
@@ skipping 177 matching lines @@
     // is redundant to also list all the sites that are blocked.
     if (this.isAllowList_())
       return true;
 
     if (this.isSessionOnlyList_())
       return siteList.length > 0;
 
     return toggleState;
   },
 });