src/objects.cc - Issue 2377983002: Allow empty first parts of ConsStrings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 2377983002: Allow empty first parts of ConsStrings (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index 828fcd896a0607ecd52aacfa7f9a0e49080c15bd..717cd8ae89b1bb5a08f70a20c743be513646ed5e 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -11092,7 +11092,7 @@ String* ConsStringIterator::NextLeaf(bool* blew_stack) {

if ((type & kStringRepresentationMask) != kConsStringTag) {

AdjustMaximumDepth();

int length = string->length();

- DCHECK(length != 0);

+ if (length == 0) break; // Skip empty left-hand sides of ConsStrings.

consumed_ += length;

return string;

}

« no previous file with comments | « no previous file | test/mjsunit/regress/regress-5440.js » ('j') | no next file with comments »