Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(192)

Issue 2377983002: Allow empty first parts of ConsStrings (Closed)

Created:
4 years, 2 months ago by jgruber
Modified:
4 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Allow empty first parts of ConsStrings TurboFan lowering (see [0]) of ConsString creation cannot ensure that the first part of the cons string is non-empty without introducing a phi and negatively impacting performance. This modifies ConsStringIterator to allow empty first parts of ConsStrings. BUG=v8:5440 Committed: https://crrev.com/da27e0c88602218b3d5bdd6056d705063b1bf792 Cr-Commit-Position: refs/heads/master@{#39817}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -7 lines) Patch
M src/objects.cc View 1 chunk +1 line, -1 line 0 comments Download
A + test/mjsunit/regress/regress-5440.js View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
jgruber
4 years, 2 months ago (2016-09-28 09:21:23 UTC) #4
Benedikt Meurer
LGTM, thanks.
4 years, 2 months ago (2016-09-28 09:30:56 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377983002/1
4 years, 2 months ago (2016-09-28 09:44:24 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 09:46:43 UTC) #10
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 09:47:05 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/da27e0c88602218b3d5bdd6056d705063b1bf792
Cr-Commit-Position: refs/heads/master@{#39817}

Powered by Google App Engine
This is Rietveld 408576698