Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2377963002: restore LOG_FATAL crash key on windows
Patch Set: move CrashMessageHandler out of base Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/child_process_logging_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 68 matching lines...) Expand 10 before | Expand all | Expand 10 after
79 // 79 //
80 // For now these need to be kept relatively up to date with those in 80 // For now these need to be kept relatively up to date with those in
81 // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys() and 81 // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys() and
82 // //blimp/engine/app/blimp_engine_crash_keys.cc 82 // //blimp/engine/app/blimp_engine_crash_keys.cc
83 constexpr base::debug::CrashKey fixed_keys[] = { 83 constexpr base::debug::CrashKey fixed_keys[] = {
84 {kMetricsClientId, kSmallSize}, 84 {kMetricsClientId, kSmallSize},
85 {kChannel, kSmallSize}, 85 {kChannel, kSmallSize},
86 {kActiveURL, kLargeSize}, 86 {kActiveURL, kLargeSize},
87 {kNumVariations, kSmallSize}, 87 {kNumVariations, kSmallSize},
88 {kVariations, kLargeSize}, 88 {kVariations, kLargeSize},
89 {kLogFatal, kLargeSize},
89 {kNumExtensionsCount, kSmallSize}, 90 {kNumExtensionsCount, kSmallSize},
90 {kShutdownType, kSmallSize}, 91 {kShutdownType, kSmallSize},
91 {kGPUVendorID, kSmallSize}, 92 {kGPUVendorID, kSmallSize},
92 {kGPUDeviceID, kSmallSize}, 93 {kGPUDeviceID, kSmallSize},
93 {kGPUDriverVersion, kSmallSize}, 94 {kGPUDriverVersion, kSmallSize},
94 {kGPUPixelShaderVersion, kSmallSize}, 95 {kGPUPixelShaderVersion, kSmallSize},
95 {kGPUVertexShaderVersion, kSmallSize}, 96 {kGPUVertexShaderVersion, kSmallSize},
96 97
97 // content/: 98 // content/:
98 {"bad_message_reason", kSmallSize}, 99 {"bad_message_reason", kSmallSize},
(...skipping 291 matching lines...) Expand 10 before | Expand all | Expand 10 after
390 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 391 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
391 return install_static::GetCollectStatsInSample(); 392 return install_static::GetCollectStatsInSample();
392 } 393 }
393 394
394 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 395 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
395 const std::string& process_type) { 396 const std::string& process_type) {
396 return process_type == install_static::kRendererProcess || 397 return process_type == install_static::kRendererProcess ||
397 process_type == install_static::kPpapiPluginProcess || 398 process_type == install_static::kPpapiPluginProcess ||
398 process_type == install_static::kGpuProcess; 399 process_type == install_static::kGpuProcess;
399 } 400 }
OLDNEW
« no previous file with comments | « blimp/engine/app/blimp_engine_crash_keys.cc ('k') | chrome/common/child_process_logging_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698