Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Side by Side Diff: blimp/engine/app/blimp_engine_crash_keys.cc

Issue 2377963002: restore LOG_FATAL crash key on windows
Patch Set: move CrashMessageHandler out of base Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « base/logging.cc ('k') | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "blimp/engine/app/blimp_engine_crash_keys.h" 5 #include "blimp/engine/app/blimp_engine_crash_keys.h"
6 6
7 #include "base/debug/crash_logging.h" 7 #include "base/debug/crash_logging.h"
8 #include "base/macros.h" 8 #include "base/macros.h"
9 #include "components/crash/core/common/crash_keys.h" 9 #include "components/crash/core/common/crash_keys.h"
10 10
11 namespace blimp { 11 namespace blimp {
12 namespace engine { 12 namespace engine {
13 13
14 size_t RegisterEngineCrashKeys() { 14 size_t RegisterEngineCrashKeys() {
15 // For now these need to be kept relatively up to date with those in 15 // For now these need to be kept relatively up to date with those in
16 // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys() 16 // //chrome/common/crash_keys.cc::RegisterChromeCrashKeys()
17 // All of the keys used in //content and //components/crash must show up 17 // All of the keys used in //content and //components/crash must show up
18 // here. 18 // here.
19 // TODO(marcinjb): Change the approach when http://crbug.com/598854 is 19 // TODO(marcinjb): Change the approach when http://crbug.com/598854 is
20 // resolved. 20 // resolved.
21 const base::debug::CrashKey engine_keys[] = { 21 const base::debug::CrashKey engine_keys[] = {
22 { crash_keys::kClientId, crash_keys::kSmallSize }, 22 { crash_keys::kClientId, crash_keys::kSmallSize },
23 { crash_keys::kChannel, crash_keys::kSmallSize }, 23 { crash_keys::kChannel, crash_keys::kSmallSize },
24 { crash_keys::kNumVariations, crash_keys::kSmallSize }, 24 { crash_keys::kNumVariations, crash_keys::kSmallSize },
25 { crash_keys::kVariations, crash_keys::kLargeSize }, 25 { crash_keys::kVariations, crash_keys::kLargeSize },
26 { crash_keys::kLogFatal, crash_keys::kLargeSize },
26 27
27 // //content crash keys 28 // //content crash keys
28 { "bad_message_reason", crash_keys::kSmallSize }, 29 { "bad_message_reason", crash_keys::kSmallSize },
29 { "channel_error_bt", crash_keys::kMediumSize }, 30 { "channel_error_bt", crash_keys::kMediumSize },
30 { "discardable-memory-allocated", crash_keys::kSmallSize }, 31 { "discardable-memory-allocated", crash_keys::kSmallSize },
31 { "discardable-memory-free", crash_keys::kSmallSize }, 32 { "discardable-memory-free", crash_keys::kSmallSize },
32 { "ppapi_path", crash_keys::kMediumSize }, 33 { "ppapi_path", crash_keys::kMediumSize },
33 { "remove_route_bt", crash_keys::kMediumSize }, 34 { "remove_route_bt", crash_keys::kMediumSize },
34 { "rwhvm_window", crash_keys::kMediumSize }, 35 { "rwhvm_window", crash_keys::kMediumSize },
35 { "subresource_url", crash_keys::kLargeSize }, 36 { "subresource_url", crash_keys::kLargeSize },
(...skipping 70 matching lines...) Expand 10 before | Expand all | Expand 10 after
106 { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize }, 107 { "swdh_get_registration_cannot_host_url", crash_keys::kLargeSize },
107 { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize }, 108 { "swdh_get_registration_cannot_document_url", crash_keys::kLargeSize },
108 }; 109 };
109 110
110 return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys), 111 return base::debug::InitCrashKeys(engine_keys, arraysize(engine_keys),
111 crash_keys::kChunkMaxLength); 112 crash_keys::kChunkMaxLength);
112 } 113 }
113 114
114 } // namespace engine 115 } // namespace engine
115 } // namespace blimp 116 } // namespace blimp
OLDNEW
« no previous file with comments | « base/logging.cc ('k') | chrome/app/chrome_crash_reporter_client_win.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698