Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(44)

Side by Side Diff: chrome/app/chrome_crash_reporter_client_win.cc

Issue 2377963002: restore LOG_FATAL crash key on windows
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 // TODO(ananta/scottmg) 5 // TODO(ananta/scottmg)
6 // Add test coverage for Crashpad. 6 // Add test coverage for Crashpad.
7 #include "chrome/app/chrome_crash_reporter_client_win.h" 7 #include "chrome/app/chrome_crash_reporter_client_win.h"
8 8
9 #include <assert.h> 9 #include <assert.h>
10 #include <windows.h> 10 #include <windows.h>
(...skipping 161 matching lines...) Expand 10 before | Expand all | Expand 10 after
172 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize}, 172 {"swdh_register_cannot_scope_url", crash_keys::kLargeSize},
173 {"swdh_register_cannot_script_url", crash_keys::kLargeSize}, 173 {"swdh_register_cannot_script_url", crash_keys::kLargeSize},
174 174
175 // Temporary for https://crbug.com/619294. 175 // Temporary for https://crbug.com/619294.
176 {"swdh_unregister_cannot_host_url", crash_keys::kLargeSize}, 176 {"swdh_unregister_cannot_host_url", crash_keys::kLargeSize},
177 {"swdh_unregister_cannot_scope_url", crash_keys::kLargeSize}, 177 {"swdh_unregister_cannot_scope_url", crash_keys::kLargeSize},
178 178
179 // Temporary for https://crbug.com/630496. 179 // Temporary for https://crbug.com/630496.
180 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize}, 180 {"swdh_get_registration_cannot_host_url", crash_keys::kLargeSize},
181 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize}, 181 {"swdh_get_registration_cannot_document_url", crash_keys::kLargeSize},
182
183 { "LOG_FATAL", crash_keys::kLargeSize },
182 }; 184 };
183 185
184 // This dynamic set of keys is used for sets of key value pairs when gathering 186 // This dynamic set of keys is used for sets of key value pairs when gathering
185 // a collection of data, like command line switches or extension IDs. 187 // a collection of data, like command line switches or extension IDs.
186 std::vector<base::debug::CrashKey> keys(fixed_keys, 188 std::vector<base::debug::CrashKey> keys(fixed_keys,
187 fixed_keys + arraysize(fixed_keys)); 189 fixed_keys + arraysize(fixed_keys));
188 190
189 crash_keys::GetCrashKeysForCommandLineSwitches(&keys); 191 crash_keys::GetCrashKeysForCommandLineSwitches(&keys);
190 192
191 // Register the extension IDs. 193 // Register the extension IDs.
(...skipping 189 matching lines...) Expand 10 before | Expand all | Expand 10 after
381 bool ChromeCrashReporterClient::GetCollectStatsInSample() { 383 bool ChromeCrashReporterClient::GetCollectStatsInSample() {
382 return install_static::GetCollectStatsInSample(); 384 return install_static::GetCollectStatsInSample();
383 } 385 }
384 386
385 bool ChromeCrashReporterClient::EnableBreakpadForProcess( 387 bool ChromeCrashReporterClient::EnableBreakpadForProcess(
386 const std::string& process_type) { 388 const std::string& process_type) {
387 return process_type == install_static::kRendererProcess || 389 return process_type == install_static::kRendererProcess ||
388 process_type == install_static::kPpapiPluginProcess || 390 process_type == install_static::kPpapiPluginProcess ||
389 process_type == install_static::kGpuProcess; 391 process_type == install_static::kGpuProcess;
390 } 392 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698