restore LOG_FATAL crash key on windows

base/logging.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/logging.h"
 
 #include <limits.h>
 #include <stdint.h>
 
 #include "base/macros.h"
@@ skipping 35 matching lines @@
 typedef pthread_mutex_t* MutexHandle;
 #endif
 
 #include <algorithm>
 #include <cstring>
 #include <ctime>
 #include <iomanip>
 #include <ostream>
 #include <string>
 
+#include "base/auto_reset.h"
 #include "base/base_switches.h"
 #include "base/command_line.h"
 #include "base/debug/alias.h"
+#include "base/debug/crash_logging.h"
 #include "base/debug/debugger.h"
 #include "base/debug/stack_trace.h"
 #include "base/posix/eintr_wrapper.h"
 #include "base/strings/string_piece.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/sys_string_conversions.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/synchronization/lock_impl.h"
 #include "base/threading/platform_thread.h"
@@ skipping 50 matching lines @@
 
 // Should we pop up fatal debug messages in a dialog?
 bool show_error_dialogs = false;
 
 // An assert handler override specified by the client to be called instead of
 // the debug message dialog and process termination.
 LogAssertHandlerFunction log_assert_handler = nullptr;
 // A log message handler that gets notified of every log message we process.
 LogMessageHandlerFunction log_message_handler = nullptr;
 
+void SetLogFatalCrashKey(size_t message_start,
+                         const std::string& string) {
+// Nacl targets miss base/debug/crash_logging.cc.

[scottmg, 2016/10/05 22:06:21]

nit; "NaCl targets do not have ..."

[rkuksin, 2016/10/06 08:50:33]

Done.

+#if !defined(NACL_TC_REV)

[scottmg, 2016/10/05 22:06:21]

OS_NACL.

[rkuksin, 2016/10/06 08:50:33]

Done.

+  // In case of an out-of-memory condition, this code could be reentered when
+  // constructing and storing the key. Using a static is not thread-safe, but if
+  // multiple threads are in the process of a fatal crash at the same time, this
+  // should work.
+  static bool guarded = false;
+  if (guarded) {
+    return;
+  }
+  base::AutoReset<bool> guard(&guarded, true);
+
+  CHECK_LE(message_start, string.size());
+  std::string message = base::StringPrintf("%s",
+                                           string.c_str() + message_start);
+  base::debug::SetCrashKeyValue("LOG_FATAL", message);

[scottmg, 2016/10/05 22:06:21]

This takes a StringPiece so no need for the Sprintfing? In fact, I would just
inline

#if !defined(OS_NACL)
if (severity_ == LOG_FATAL)
  base::debug::SetCrashKeyValue("LOG_FATAL", StringPiece(...)) 
#endif  // OS_NACL

below instead.

[rkuksin, 2016/10/06 08:50:33]

Done.

+#endif  // !defined(NACL_TC_REV)
+}
+
 // Helper functions to wrap platform differences.
 
 int32_t CurrentProcessId() {
 #if defined(OS_WIN)
   return GetCurrentProcessId();
 #elif defined(OS_POSIX)
   return getpid();
 #endif
 }
 
@@ skipping 391 matching lines @@
   if (severity_ == LOG_FATAL && !base::debug::BeingDebugged()) {
     // Include a stack trace on a fatal, unless a debugger is attached.
     base::debug::StackTrace trace;
     stream_ << std::endl;  // Newline to separate from log message.
     trace.OutputToStream(&stream_);
   }
 #endif
   stream_ << std::endl;
   std::string str_newline(stream_.str());
 
+  if (severity_ == LOG_FATAL) {
+    SetLogFatalCrashKey(message_start_, str_newline);
+  }
+
   // Give any log message handler first dibs on the message.
   if (log_message_handler &&
       log_message_handler(severity_, file_, line_,
                           message_start_, str_newline)) {
     // The handler took care of it, no further processing.
     return;
   }
 
   if ((g_logging_destination & LOG_TO_SYSTEM_DEBUG_LOG) != 0) {
 #if defined(OS_WIN)
@@ skipping 371 matching lines @@
 BASE_EXPORT void LogErrorNotReached(const char* file, int line) {
   LogMessage(file, line, LOG_ERROR).stream()
       << "NOTREACHED() hit.";
 }
 
 }  // namespace logging
 
 std::ostream& std::operator<<(std::ostream& out, const wchar_t* wstr) {
   return out << (wstr ? base::WideToUTF8(wstr) : std::string());
 }