Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 2377953003: CSS style invalidation: simplify updates to invalidation set collections (Closed)

Created:
4 years, 2 months ago by Eric Willigers
Modified:
4 years, 2 months ago
Reviewers:
esprehn, sashab, rune
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CSS style invalidation: simplify updates to invalidation set collections ensureInvalidationSet is no longer a template method. We now access each AddResult only once. BUG=412572 Committed: https://crrev.com/73b59942f417a8c27030ec246ea8e3111fe712c5 Cr-Commit-Position: refs/heads/master@{#422080}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -14 lines) Patch
M third_party/WebKit/Source/core/css/RuleFeature.cpp View 1 chunk +23 lines, -14 lines 0 comments Download

Messages

Total messages: 16 (9 generated)
Eric Willigers
4 years, 2 months ago (2016-09-30 01:17:49 UTC) #6
Eric Willigers
ensureInvalidationSet is now a non-template method, in case the problem is a Visual C++ compiler ...
4 years, 2 months ago (2016-09-30 01:24:04 UTC) #8
rune
lgtm
4 years, 2 months ago (2016-09-30 09:40:54 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377953003/1
4 years, 2 months ago (2016-09-30 09:47:02 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-30 11:16:43 UTC) #12
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/73b59942f417a8c27030ec246ea8e3111fe712c5 Cr-Commit-Position: refs/heads/master@{#422080}
4 years, 2 months ago (2016-09-30 11:18:19 UTC) #14
sashab
4 years, 2 months ago (2016-10-04 02:46:13 UTC) #16
Message was sent while issue was closed.
\o/ this patch is awesome.

Powered by Google App Engine
This is Rietveld 408576698