Make hasPendingActivity return false after the associated browsing context is detached

Make hasPendingActivity return false after the associated browsing context is detached

Currently some hasPendingActivitity's are mis-implemented and keep returning true forever.
Then the entire window object can leak. As a work-around to avoid the leak, this CL adds logic
to ignore the result of hasPendingActivity when the associated window object is detached.

See bug 650146 for more detailed context.

BUG=650146
Committed: https://crrev.com/62da61e28d18afa418de5bf2f070e8d56d766b4b
Cr-Commit-Position: refs/heads/master@{#422378}

[haraken, 2016-09-28 06:03:59]

The CQ bit was checked by haraken@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-28 06:04:12]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-28 07:15:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-28 07:16:00]

Dry run: This issue passed the CQ dry run.

[haraken, 2016-09-28 07:52:37]

Description was changed from

==========
Make hasPendingActivity return false after the associated browsing context is
detached

BUG=650146
==========

to

==========
Make hasPendingActivity return false after the associated browsing context is
detached

Currently some hasPendingActivitity's are mis-implemented and keep returning
true forever.
Then the entire window object can leak. As a work-around to avoid the leak, this
CL adds logic
to ignore the result of hasPendingActivity when the associated window object is
detached.

See bug 650146 for more detailed context.

BUG=650146
==========

[haraken, 2016-09-28 07:52:37]

haraken@chromium.org changed reviewers:
+ hiroshige@chromium.org, jochen@chromium.org, kouhei@chromium.org

[haraken, 2016-09-28 07:53:18]

All tests pass.

kouhei@, hiroshige@: Would you check if this doesn't break any lifetime
assumption around unload handlers and XHR?

jochen@: PTAL

[jochen (gone - plz use gerrit), 2016-09-29 12:00:56]

lgtm

[haraken, 2016-09-29 12:22:02]

kouhei@, hiroshige@: Are you fine with landing this?

[kouhei (in TOK), 2016-09-30 04:20:37]

lgtm but I want hiroshige@'s look on this too.

[hiroshige, 2016-10-03 05:21:15]

On 2016/09/30 04:20:37, kouhei wrote:
> lgtm but I want hiroshige@'s look on this too.

lgtm. I expect this doesn't affect XHR because loading is cancelled when
ExecutionContext is stopped (in blink::XMLHttpRequest::stop()).

[haraken, 2016-10-03 05:31:58]

The CQ bit was checked by haraken@chromium.org

[haraken, 2016-10-03 05:31:58]

The patchset sent to the CQ was uploaded after l-g-t-m from
hiroshige@chromium.org, jochen@chromium.org, kouhei@chromium.org
Link to the patchset: https://codereview.chromium.org/2377953002/#ps20001
(title: "temp")

[commit-bot: I haz the power, 2016-10-03 05:32:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-03 06:40:35]

Description was changed from

==========
Make hasPendingActivity return false after the associated browsing context is
detached

Currently some hasPendingActivitity's are mis-implemented and keep returning
true forever.
Then the entire window object can leak. As a work-around to avoid the leak, this
CL adds logic
to ignore the result of hasPendingActivity when the associated window object is
detached.

See bug 650146 for more detailed context.

BUG=650146
==========

to

==========
Make hasPendingActivity return false after the associated browsing context is
detached

Currently some hasPendingActivitity's are mis-implemented and keep returning
true forever.
Then the entire window object can leak. As a work-around to avoid the leak, this
CL adds logic
to ignore the result of hasPendingActivity when the associated window object is
detached.

See bug 650146 for more detailed context.

BUG=650146
==========

[commit-bot: I haz the power, 2016-10-03 06:40:36]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-03 06:42:08]

Description was changed from

==========
Make hasPendingActivity return false after the associated browsing context is
detached

Currently some hasPendingActivitity's are mis-implemented and keep returning
true forever.
Then the entire window object can leak. As a work-around to avoid the leak, this
CL adds logic
to ignore the result of hasPendingActivity when the associated window object is
detached.

See bug 650146 for more detailed context.

BUG=650146
==========

to

==========
Make hasPendingActivity return false after the associated browsing context is
detached

Currently some hasPendingActivitity's are mis-implemented and keep returning
true forever.
Then the entire window object can leak. As a work-around to avoid the leak, this
CL adds logic
to ignore the result of hasPendingActivity when the associated window object is
detached.

See bug 650146 for more detailed context.

BUG=650146

Committed: https://crrev.com/62da61e28d18afa418de5bf2f070e8d56d766b4b
Cr-Commit-Position: refs/heads/master@{#422378}
==========

[commit-bot: I haz the power, 2016-10-03 06:42:09]

Patchset 2 (id:??) landed as
https://crrev.com/62da61e28d18afa418de5bf2f070e8d56d766b4b
Cr-Commit-Position: refs/heads/master@{#422378}