Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2377903002: [wasm] [asm.js] Fix various asm.js issues. (Closed)

Created:
4 years, 2 months ago by bradnelson
Modified:
4 years, 2 months ago
Reviewers:
aseemgarg, bradn, John
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] [asm.js] Fix various asm.js issues. Several of the asm.js tests were disabled and wrong (mismatched number of args on the stdlib functions). Fixing issue around negation and float + doubles. Renaming function for IsNegate to IsInvert (to reflect what it actually does). Added tests for negate and invert. BUG= https://bugs.chromium.org/p/v8/issues/detail?id=4203 R=aseemgarg@chromium.org,jpp@chromium.org Committed: https://crrev.com/21e46b05a26024173a36599d2784a657cedc5b2b Cr-Commit-Position: refs/heads/master@{#39836}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -22 lines) Patch
M src/asmjs/asm-typer.cc View 4 chunks +5 lines, -5 lines 0 comments Download
M src/asmjs/asm-wasm-builder.cc View 1 chunk +18 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-f32.js View 2 chunks +6 lines, -0 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-f64.js View 2 chunks +21 lines, -16 lines 0 comments Download
M test/mjsunit/wasm/asm-wasm-i32.js View 2 chunks +13 lines, -1 line 2 comments Download
M test/mjsunit/wasm/asm-wasm-u32.js View 2 chunks +12 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (7 generated)
bradn
4 years, 2 months ago (2016-09-28 02:13:59 UTC) #4
aseemgarg
lgtm lgtm https://codereview.chromium.org/2377903002/diff/1/test/mjsunit/wasm/asm-wasm-i32.js File test/mjsunit/wasm/asm-wasm-i32.js (right): https://codereview.chromium.org/2377903002/diff/1/test/mjsunit/wasm/asm-wasm-i32.js#newcode241 test/mjsunit/wasm/asm-wasm-i32.js:241: i32_invert, is the last comma allowed?
4 years, 2 months ago (2016-09-28 06:23:39 UTC) #7
John
lgtm
4 years, 2 months ago (2016-09-28 12:25:41 UTC) #8
bradn
https://codereview.chromium.org/2377903002/diff/1/test/mjsunit/wasm/asm-wasm-i32.js File test/mjsunit/wasm/asm-wasm-i32.js (right): https://codereview.chromium.org/2377903002/diff/1/test/mjsunit/wasm/asm-wasm-i32.js#newcode241 test/mjsunit/wasm/asm-wasm-i32.js:241: i32_invert, On 2016/09/28 06:23:39, aseemgarg wrote: > is the ...
4 years, 2 months ago (2016-09-28 16:33:53 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377903002/1
4 years, 2 months ago (2016-09-28 16:34:01 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 16:36:45 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 16:37:16 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/21e46b05a26024173a36599d2784a657cedc5b2b
Cr-Commit-Position: refs/heads/master@{#39836}

Powered by Google App Engine
This is Rietveld 408576698