content/browser/web_contents/web_contents_impl.cc - Issue 2377833002: Block navigations in extensions via ShouldTransferNavigation (not via OpenURL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 2377833002: Block navigations in extensions via ShouldTransferNavigation (not via OpenURL). (Closed)

Patch Set: Add missing files under chrome/test/data/extensions/api_test/browser_action/popup_with_form/ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 21ca407b9e5bebb5128702dd2890e1842d230244..fa8b62286a971a908f1d590db633324e3b7e4b21 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -3352,10 +3352,10 @@ void WebContentsImpl::RequestOpenURL(RenderFrameHostImpl* render_frame_host,

}

-bool WebContentsImpl::ShouldTransferNavigation() {

+bool WebContentsImpl::ShouldTransferNavigation(bool is_main_frame_navigation) {

if (!delegate_)

return true;

- return delegate_->ShouldTransferNavigation();

+ return delegate_->ShouldTransferNavigation(is_main_frame_navigation);

}

bool WebContentsImpl::ShouldPreserveAbortedURLs() {