content/browser/frame_host/navigation_request.cc - Issue 2377833002: Block navigations in extensions via ShouldTransferNavigation (not via OpenURL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigation_request.cc

Issue 2377833002: Block navigations in extensions via ShouldTransferNavigation (not via OpenURL). (Closed)

Patch Set: Add missing files under chrome/test/data/extensions/api_test/browser_action/popup_with_form/ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigation_request.cc

diff --git a/content/browser/frame_host/navigation_request.cc b/content/browser/frame_host/navigation_request.cc

index 2fb9cd8b4aff67ff181800ee77f1e0c96dbd378f..8a5f727de833ba00c6124e724361f259af5dc102 100644

--- a/content/browser/frame_host/navigation_request.cc

+++ b/content/browser/frame_host/navigation_request.cc

@@ -386,9 +386,8 @@ void NavigationRequest::OnResponseStarted(

// renderer, allow the embedder to cancel the transfer.

if (!browser_initiated_ &&

render_frame_host != frame_tree_node_->current_frame_host() &&

- !frame_tree_node_->navigator()

- ->GetDelegate()

- ->ShouldTransferNavigation()) {

+ !frame_tree_node_->navigator()->GetDelegate()->ShouldTransferNavigation(

+ frame_tree_node_->IsMainFrame())) {

frame_tree_node_->ResetNavigationRequest(false);

return;

}