chrome/browser/prerender/prerender_contents.cc - Issue 2377833002: Block navigations in extensions via ShouldTransferNavigation (not via OpenURL).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/prerender/prerender_contents.cc

Issue 2377833002: Block navigations in extensions via ShouldTransferNavigation (not via OpenURL). (Closed)

Patch Set: Add missing files under chrome/test/data/extensions/api_test/browser_action/popup_with_form/ Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/prerender/prerender_contents.cc

diff --git a/chrome/browser/prerender/prerender_contents.cc b/chrome/browser/prerender/prerender_contents.cc

index 890008ada304554b0708e70fb887261be35f8afd..a8eaeb8f313d58aaf68b4117660ccd522ae9a161 100644

--- a/chrome/browser/prerender/prerender_contents.cc

+++ b/chrome/browser/prerender/prerender_contents.cc

@@ -112,7 +112,7 @@ class PrerenderContents::WebContentsDelegateImpl

return NULL;

}

- bool ShouldTransferNavigation() override {

+ bool ShouldTransferNavigation(bool is_main_frame_navigation) override {

// Cancel the prerender if the navigation attempts to transfer to a

// different process. Examples include server redirects to privileged pages

// or cross-site subframe navigations in --site-per-process.