Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Issue 2377813002: kernel->ssa: implement for-in loops (Closed)

Created:
4 years, 2 months ago by Harry Terkelsen
Modified:
4 years, 2 months ago
Reviewers:
Johnni Winther, sra1
CC:
reviews_dartlang.org, dart-kernel+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : fix import #

Patch Set 3 : fix another import #

Unified diffs Side-by-side diffs Delta from patch set Stats (+373 lines, -76 lines) Patch
M pkg/compiler/lib/src/kernel/kernel_visitor.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +1 line, -18 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder_kernel.dart View 1 2 7 chunks +195 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_ast_adapter.dart View 1 8 chunks +98 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/ssa/locals_handler.dart View 2 chunks +18 lines, -1 line 0 comments Download
M tests/compiler/dart2js/kernel/helper.dart View 2 chunks +14 lines, -5 lines 0 comments Download
M tests/compiler/dart2js/kernel/loops_test.dart View 3 chunks +44 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Harry Terkelsen
4 years, 2 months ago (2016-09-27 21:55:38 UTC) #2
Johnni Winther
lgtm
4 years, 2 months ago (2016-09-28 12:47:11 UTC) #3
Harry Terkelsen
4 years, 2 months ago (2016-09-28 17:20:33 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
71613d72a875268c14060a5e41a834e9738ebd8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698