Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Issue 2377763002: Added kSRGBLinear_Named color space, along with tests (Closed)

Created:
4 years, 2 months ago by Brian Osman
Modified:
4 years, 2 months ago
Reviewers:
msarett, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Added kSRGBLinear_Named color space, along with tests Gradients (and other shaders) are going to end up serializing this particular color space very frequently, so we want a shorthand way of writing it out. I think it's also helpful to have a clearer way of creating it (vs. NewNamed(kSRGB_Named)->makeLinearGamma()). BUG=skia: GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2377763002 Committed: https://skia.googlesource.com/skia/+/eec8304714f35e4c789a2b69e511f88fe5890149

Patch Set 1 #

Patch Set 2 : Update some call sites #

Total comments: 3

Patch Set 3 : Update assert. Better comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+68 lines, -17 lines) Patch
M gm/colorspacexform.cpp View 1 1 chunk +1 line, -2 lines 0 comments Download
M include/core/SkColorSpace.h View 1 2 1 chunk +6 lines, -0 lines 0 comments Download
M src/core/SkColorSpace.cpp View 1 2 5 chunks +27 lines, -1 line 0 comments Download
M src/effects/gradients/SkGradientShader.cpp View 1 2 chunks +4 lines, -5 lines 0 comments Download
M tests/ColorSpaceTest.cpp View 3 chunks +29 lines, -8 lines 0 comments Download
M tests/SurfaceTest.cpp View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (7 generated)
Brian Osman
https://codereview.chromium.org/2377763002/diff/20001/src/core/SkColorSpace.cpp File src/core/SkColorSpace.cpp (right): https://codereview.chromium.org/2377763002/diff/20001/src/core/SkColorSpace.cpp#newcode294 src/core/SkColorSpace.cpp:294: return sizeof(ColorSpaceHeader); Unrelated bug fix. (Discovered this while making ...
4 years, 2 months ago (2016-09-27 20:49:49 UTC) #3
msarett
lgtm https://codereview.chromium.org/2377763002/diff/20001/include/core/SkColorSpace.h File include/core/SkColorSpace.h (right): https://codereview.chromium.org/2377763002/diff/20001/include/core/SkColorSpace.h#newcode36 include/core/SkColorSpace.h:36: * Colorspace with the sRGB primaries, but a ...
4 years, 2 months ago (2016-09-27 20:53:52 UTC) #4
reed1
lgtm
4 years, 2 months ago (2016-09-27 21:04:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377763002/20001
4 years, 2 months ago (2016-09-27 21:25:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot on master.client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-GN-Trybot/builds/1549)
4 years, 2 months ago (2016-09-27 21:31:40 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377763002/40001
4 years, 2 months ago (2016-09-27 21:35:50 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:11:50 UTC) #14
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/eec8304714f35e4c789a2b69e511f88fe5890149

Powered by Google App Engine
This is Rietveld 408576698