Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(77)

Issue 2377743003: Revert of Disable flaky browser tests on Mac. (Closed)

Created:
4 years, 2 months ago by tommycli
Modified:
4 years, 2 months ago
Reviewers:
loyso (OOO)
CC:
chromium-reviews, jam
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Disable flaky browser tests on Mac. (patchset #1 id:1 of https://codereview.chromium.org/1868863003/ ) Reason for revert: Flakiness should have been fixed. See bug. Original issue's description: > Disable flaky browser tests on Mac. > > BUG=599484 > TBR=tommycli@chromium.org > > Committed: https://crrev.com/bce1b56007d9e70b8b926781b2a3deb340046b83 > Cr-Commit-Position: refs/heads/master@{#385664} TBR=loyso@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=599484 Committed: https://crrev.com/0983d3b2372bd46ec38d4ebc0b4fa06f286ff4d9 Cr-Commit-Position: refs/heads/master@{#421355}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -14 lines) Patch
M chrome/browser/plugins/plugin_power_saver_browsertest.cc View 2 chunks +2 lines, -14 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
tommycli
Created Revert of Disable flaky browser tests on Mac.
4 years, 2 months ago (2016-09-27 21:38:06 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377743003/1
4 years, 2 months ago (2016-09-27 21:38:27 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 22:08:28 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0983d3b2372bd46ec38d4ebc0b4fa06f286ff4d9 Cr-Commit-Position: refs/heads/master@{#421355}
4 years, 2 months ago (2016-09-27 22:10:47 UTC) #6
loyso (OOO)
4 years, 2 months ago (2016-09-28 00:17:21 UTC) #7
Message was sent while issue was closed.
I'm not sure that the flakiness is fixed. The bug is blocked on
https://bugs.chromium.org/p/chromium/issues/detail?id=462580
That issue still exists.

Powered by Google App Engine
This is Rietveld 408576698