Support SystemTrayDelegate::ShowPowerSettings() in mustash

ash/mus/system_tray_delegate_mus.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/mus/system_tray_delegate_mus.h"
 
 #include "ash/common/system/tray/system_tray_notifier.h"
 #include "ash/common/wm_shell.h"
 #include "base/bind.h"
 #include "base/bind_helpers.h"
@@ skipping 61 matching lines @@
     const std::string& guid) {
   // http://crbug.com/647412
   NOTIMPLEMENTED();
 }
 
 void SystemTrayDelegateMus::ShowDisplaySettings() {
   ConnectToSystemTrayClient()->ShowDisplaySettings();
 }
 
 void SystemTrayDelegateMus::ShowPowerSettings() {
-  // http://crbug.com/647412
-  NOTIMPLEMENTED();
+  ConnectToSystemTrayClient()->ShowPowerSettings();

[michaelpg, 2016/09/28 23:09:15]

does this mean power_handler.cc be updated as well to support mash?
https://cs.chromium.org/chromium/src/chrome/browser/ui/webui/options/chromeos...

If not, then this would just open Settings for no reason.

[James Cook, 2016/09/29 15:28:29]

Yes, power_handler.cc will need to be updated to support mash, but I would
prefer to do that in a separate CL. Updating PowerHandler will require
initializing PowerStatus in the ash process, which will trigger additional D-Bus
traffic to powerd via PowerManagerClient. I am not completely certain that I can
do that safely with PowerStatus as it exists today. See discussion in
crbug.com/644348

Right now under mash this CL opens battery status with battery info at 50%,
which I suspect is just hard-coded into the HTML as the default. It doesn't
update, but it does open something.

If you would prefer me to wait on this CL until PowerStatus is sorted out I'm
happy to do that.

[michaelpg, 2016/09/29 17:00:51]

The only reason to open Settings from the notification (and the only reason to
show the notification) is to give the user the ability to change power source.

On the other hand, I guess this is better than a NOTIMPLEMENTED(). So I'll leave
it up to you what order you want to land things in.

 }
 
 void SystemTrayDelegateMus::ShowChromeSlow() {
   ConnectToSystemTrayClient()->ShowChromeSlow();
 }
 
 void SystemTrayDelegateMus::ShowIMESettings() {
   ConnectToSystemTrayClient()->ShowIMESettings();
 }
 
@@ skipping 32 matching lines @@
 
 ////////////////////////////////////////////////////////////////////////////////
 // mojom::SystemTray:
 
 void SystemTrayDelegateMus::SetUse24HourClock(bool use_24_hour) {
   hour_clock_type_ = use_24_hour ? base::k24HourClock : base::k12HourClock;
   WmShell::Get()->system_tray_notifier()->NotifyDateFormatChanged();
 }
 
 }  // namespace ash