Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(967)

Issue 2377703002: Made PlatformWheelEvent a subclass of PlatformMouseEvent. (Closed)

Created:
4 years, 2 months ago by mustaq
Modified:
4 years, 2 months ago
Reviewers:
dtapuska, Rick Byers
CC:
chromium-reviews, blink-reviews, blink-reviews-events_chromium.org, dglazkov+blink, dtapuska+blinkwatch_chromium.org, eae+blinkwatch
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Made PlatformWheelEvent a subclass of PlatformMouseEvent. This makes the class hierarchy same for Platform & Web wheel events. BUG=649399 Committed: https://crrev.com/9ead89c0689ca05e34e09fb0087d574b823f12f5 Cr-Commit-Position: refs/heads/master@{#421636}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -8 lines) Patch
M third_party/WebKit/Source/platform/PlatformMouseEvent.h View 1 chunk +6 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/PlatformWheelEvent.h View 4 chunks +3 lines, -7 lines 0 comments Download

Messages

Total messages: 15 (8 generated)
mustaq
ptal.
4 years, 2 months ago (2016-09-27 17:10:00 UTC) #2
dtapuska
On 2016/09/27 17:10:00, mustaq wrote: > ptal. lgtm
4 years, 2 months ago (2016-09-27 17:21:57 UTC) #3
mustaq
Need approval in: Source/platform
4 years, 2 months ago (2016-09-27 17:28:03 UTC) #5
Rick Byers
LGTM
4 years, 2 months ago (2016-09-28 19:24:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377703002/1
4 years, 2 months ago (2016-09-28 19:27:27 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 20:50:37 UTC) #13
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 20:53:18 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9ead89c0689ca05e34e09fb0087d574b823f12f5
Cr-Commit-Position: refs/heads/master@{#421636}

Powered by Google App Engine
This is Rietveld 408576698