Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(523)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 23777006: telemetry: Add webkit.console category to event category filter. (Closed)

Created:
7 years, 3 months ago by ernstm
Modified:
7 years, 3 months ago
Reviewers:
nduca, tonyg
CC:
chromium-reviews, chrome-speed-team+watch_google.com
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

telemetry: Add webkit.console category to event category filter. Once https://codereview.chromium.org/23848006/ has landed, we can remove the webkit category, and leave only webkit.console. R=nduca@chromium.org, tonyg@chromium.org BUG=264308 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=221616

Patch Set 1 #

Total comments: 2

Patch Set 2 : Added TODO to remove 'webkit' category. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M tools/perf/measurements/rasterize_and_record.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/perf/measurements/smoothness.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ernstm
7 years, 3 months ago (2013-09-05 20:43:55 UTC) #1
tonyg
lgtm https://codereview.chromium.org/23777006/diff/1/tools/perf/measurements/rasterize_and_record.py File tools/perf/measurements/rasterize_and_record.py (right): https://codereview.chromium.org/23777006/diff/1/tools/perf/measurements/rasterize_and_record.py#newcode150 tools/perf/measurements/rasterize_and_record.py:150: tab.browser.StartTracing('webkit,webkit.console,benchmark', 60) Maybe add a TODO about removing ...
7 years, 3 months ago (2013-09-05 21:04:20 UTC) #2
ernstm
https://codereview.chromium.org/23777006/diff/1/tools/perf/measurements/rasterize_and_record.py File tools/perf/measurements/rasterize_and_record.py (right): https://codereview.chromium.org/23777006/diff/1/tools/perf/measurements/rasterize_and_record.py#newcode150 tools/perf/measurements/rasterize_and_record.py:150: tab.browser.StartTracing('webkit,webkit.console,benchmark', 60) On 2013/09/05 21:04:20, tonyg wrote: > Maybe ...
7 years, 3 months ago (2013-09-05 22:29:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ernstm@chromium.org/23777006/5001
7 years, 3 months ago (2013-09-05 22:29:49 UTC) #4
commit-bot: I haz the power
7 years, 3 months ago (2013-09-06 06:52:52 UTC) #5
Message was sent while issue was closed. 
Change committed as 221616

Powered by Google App Engine
This is Rietveld 408576698