Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Side by Side Diff: tools/run-bisect-manual-test.py

Issue 23777002: Adding comment to inform the user to set up the sandbox manually on Linux. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Check if CHROME_DEVEL_SANDBOX environment variable is set. Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 # Copyright 2013 The Chromium Authors. All rights reserved. 2 # Copyright 2013 The Chromium Authors. All rights reserved.
3 # Use of this source code is governed by a BSD-style license that can be 3 # Use of this source code is governed by a BSD-style license that can be
4 # found in the LICENSE file. 4 # found in the LICENSE file.
5 5
6 """Run Manual Test Bisect Tool 6 """Run Manual Test Bisect Tool
7 7
8 An example usage: 8 An example usage:
9 tools/run-bisect-manual-test.py -g 201281 -b 201290 9 tools/run-bisect-manual-test.py -g 201281 -b 201290
10 10
11 On Linux platform, follow the instructions in this document
12 https://code.google.com/p/chromium/wiki/LinuxSUIDSandboxDevelopment
13 to setup the sandbox manually before running the script. Otherwise the script
14 fails to launch Chrome and exits with an error.
15
11 """ 16 """
12 17
13 import os 18 import os
14 import subprocess 19 import subprocess
15 import sys 20 import sys
16 21
17 CROS_BOARD_ENV = 'BISECT_CROS_BOARD' 22 CROS_BOARD_ENV = 'BISECT_CROS_BOARD'
18 CROS_IP_ENV = 'BISECT_CROS_IP' 23 CROS_IP_ENV = 'BISECT_CROS_IP'
19 _DIR_TOOLS_ROOT = os.path.abspath(os.path.dirname(__file__)) 24 _DIR_TOOLS_ROOT = os.path.abspath(os.path.dirname(__file__))
20 25
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
102 if not options.good_revision: 107 if not options.good_revision:
103 error_msg += 'Error: missing required parameter: --good_revision\n' 108 error_msg += 'Error: missing required parameter: --good_revision\n'
104 if not options.bad_revision: 109 if not options.bad_revision:
105 error_msg += 'Error: missing required parameter: --bad_revision\n' 110 error_msg += 'Error: missing required parameter: --bad_revision\n'
106 111
107 if error_msg: 112 if error_msg:
108 print error_msg 113 print error_msg
109 parser.print_help() 114 parser.print_help()
110 return 1 115 return 1
111 116
117 if os.name == 'posix':
tonyg 2013/08/29 22:39:19 os.name == 'posix' includes Mac which does not use
pshenoy 2013/08/29 22:46:24 Done.
118 if os.environ.get('CHROME_DEVEL_SANDBOX') == None:
tonyg 2013/08/29 22:39:19 The style guide says not to compare to None explic
pshenoy 2013/08/29 22:46:24 Done.
119 print 'SUID sandbox has not been setup.'\
120 ' See https://code.google.com/p/chromium/wiki/'\
121 'LinuxSUIDSandboxDevelopment for more information.'
122 return 1
123
112 return _RunBisectionScript(options) 124 return _RunBisectionScript(options)
113 125
114 126
115 if __name__ == '__main__': 127 if __name__ == '__main__':
116 sys.exit(main()) 128 sys.exit(main())
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698