Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Unified Diff: third_party/crashpad/crashpad/client/crashpad_client_win.cc

Issue 2377693002: TerminateProcess if DumpAndCrash called without registration (Closed)
Patch Set: self-terminate instead Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/client/crashpad_client_win.cc
diff --git a/third_party/crashpad/crashpad/client/crashpad_client_win.cc b/third_party/crashpad/crashpad/client/crashpad_client_win.cc
index 40a3b093df216a9ce5325f4fe5e468447847a4d0..ee154c641c39d2674c6c04fe77f6c89377c22a02 100644
--- a/third_party/crashpad/crashpad/client/crashpad_client_win.cc
+++ b/third_party/crashpad/crashpad/client/crashpad_client_win.cc
@@ -487,8 +487,9 @@ void CrashpadClient::DumpWithoutCrash(const CONTEXT& context) {
// static
void CrashpadClient::DumpAndCrash(EXCEPTION_POINTERS* exception_pointers) {
if (g_signal_exception == INVALID_HANDLE_VALUE) {
- LOG(ERROR) << "haven't called UseHandler()";
- return;
+ LOG(ERROR) << "haven't called UseHandler(), no dump captured";
+ const UINT kCrashUnregistered = 0xffff7003;
Mark Mentovai 2016/09/27 18:15:28 Seems like maybe we should have a common home for
+ TerminateProcess(GetCurrentProcess(), kCrashUnregistered);
}
UnhandledExceptionHandler(exception_pointers);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698