Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2377683003: [wasm] resolve mips build error post 0xC land (Closed)

Created:
4 years, 2 months ago by Mircea Trofin
Modified:
4 years, 2 months ago
Reviewers:
titzer, bradnelson, bradn
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[wasm] resolve mips build error post 0xC land BUG= Committed: https://crrev.com/fa071284ed74180544de9396e4f8db2b0723bb47 Cr-Commit-Position: refs/heads/master@{#39796}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M test/unittests/wasm/module-decoder-unittest.cc View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
Mircea Trofin
4 years, 2 months ago (2016-09-27 21:33:32 UTC) #6
bradn
lgtm
4 years, 2 months ago (2016-09-27 22:04:56 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377683003/1
4 years, 2 months ago (2016-09-27 22:05:02 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 22:09:40 UTC) #14
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 22:10:01 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fa071284ed74180544de9396e4f8db2b0723bb47
Cr-Commit-Position: refs/heads/master@{#39796}

Powered by Google App Engine
This is Rietveld 408576698