Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 2377683002: Set speculative bool on dns-preresolves in //content (Closed)

Created:
4 years, 2 months ago by Charlie Harrison
Modified:
4 years, 2 months ago
CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Set speculative bool on dns-preresolves in //content This bit is only used to separate DNS requests in histograms. BUG=650693 Committed: https://crrev.com/9d561b84341f15e7926fcdb5e762c51a996449bc Cr-Commit-Position: refs/heads/master@{#421245}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M content/browser/loader/resource_hints_impl.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 18 (10 generated)
Charlie Harrison
juliatuttle@, ptal?
4 years, 2 months ago (2016-09-27 16:27:49 UTC) #4
Randy Smith (Not in Mondays)
Drive by comment, mostly driven by curiosity (but I think the answer should be in ...
4 years, 2 months ago (2016-09-27 16:29:29 UTC) #6
Charlie Harrison
Updated the CL description. There aren't any user facing changes in this patch (speculative dns ...
4 years, 2 months ago (2016-09-27 16:34:12 UTC) #8
Randy Smith (Not in Mondays)
TY. LGTM (just to get myself out of the way :-}).
4 years, 2 months ago (2016-09-27 16:36:33 UTC) #9
Julia Tuttle
lgtm.
4 years, 2 months ago (2016-09-27 17:10:16 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377683002/1
4 years, 2 months ago (2016-09-27 17:11:05 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 17:17:10 UTC) #16
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:21:02 UTC) #18
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9d561b84341f15e7926fcdb5e762c51a996449bc
Cr-Commit-Position: refs/heads/master@{#421245}

Powered by Google App Engine
This is Rietveld 408576698