|
|
Created:
4 years, 2 months ago by Charlie Harrison Modified:
4 years, 2 months ago CC:
chromium-reviews, loading-reviews_chromium.org, jam, darin-cc_chromium.org, Randy Smith (Not in Mondays), mmenke Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSet speculative bool on dns-preresolves in //content
This bit is only used to separate DNS requests in histograms.
BUG=650693
Committed: https://crrev.com/9d561b84341f15e7926fcdb5e762c51a996449bc
Cr-Commit-Position: refs/heads/master@{#421245}
Patch Set 1 #
Messages
Total messages: 18 (10 generated)
The CQ bit was checked by csharrison@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
csharrison@chromium.org changed reviewers: + juliatuttle@chromium.org
juliatuttle@, ptal?
rdsmith@chromium.org changed reviewers: + rdsmith@chromium.org
Drive by comment, mostly driven by curiosity (but I think the answer should be in the CL description, so I'll let Rietveld "reviewer" me :-}): What's the user-facing change in behavior expected from this CL?
Description was changed from ========== Set speculative bool on dns-preresolves in //content BUG=650693 ========== to ========== Set speculative bool on dns-preresolves in //content This bit is only used to separate DNS requests in histograms. BUG=650693 ==========
Updated the CL description. There aren't any user facing changes in this patch (speculative dns requests are already lowest priority).
TY. LGTM (just to get myself out of the way :-}).
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
lgtm.
The CQ bit was checked by csharrison@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Set speculative bool on dns-preresolves in //content This bit is only used to separate DNS requests in histograms. BUG=650693 ========== to ========== Set speculative bool on dns-preresolves in //content This bit is only used to separate DNS requests in histograms. BUG=650693 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Set speculative bool on dns-preresolves in //content This bit is only used to separate DNS requests in histograms. BUG=650693 ========== to ========== Set speculative bool on dns-preresolves in //content This bit is only used to separate DNS requests in histograms. BUG=650693 Committed: https://crrev.com/9d561b84341f15e7926fcdb5e762c51a996449bc Cr-Commit-Position: refs/heads/master@{#421245} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/9d561b84341f15e7926fcdb5e762c51a996449bc Cr-Commit-Position: refs/heads/master@{#421245} |