Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Unified Diff: components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc

Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID (Closed)
Patch Set: rebase Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc
diff --git a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc
index 039ac5b9869cb720d987cbf5314fd4d462041c44..4ad0254f95b4289325ab113e61d0dbc7dafa5cd4 100644
--- a/components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc
+++ b/components/ntp_snippets/offline_pages/offline_page_suggestions_provider_unittest.cc
@@ -134,8 +134,8 @@ class OfflinePageSuggestionsProviderTest : public testing::Test {
return category_factory_.FromKnownCategory(KnownCategories::DOWNLOADS);
}
- std::string GetDummySuggestionId(Category category, int id) {
- return provider_->MakeUniqueID(category, base::IntToString(id));
+ ContentSuggestion::ID GetDummySuggestionId(Category category, int id) {
+ return ContentSuggestion::ID(category, base::IntToString(id));
}
ContentSuggestion CreateDummySuggestion(Category category, int id) {
@@ -348,10 +348,9 @@ TEST_F(OfflinePageSuggestionsProviderTest,
FireOfflinePageModelChanged();
// Invalidation of suggestion 2 should be forwarded.
- EXPECT_CALL(
- *observer(),
- OnSuggestionInvalidated(_, recent_tabs_category(),
- GetDummySuggestionId(recent_tabs_category(), 2)));
+ EXPECT_CALL(*observer(),
+ OnSuggestionInvalidated(
+ _, GetDummySuggestionId(recent_tabs_category(), 2)));
FireOfflinePageDeleted(model()->items().at(1));
}

Powered by Google App Engine
This is Rietveld 408576698