Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/browser/android/ntp/ntp_snippets_bridge.h

Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID (Closed)
Patch Set: . Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/ntp/ntp_snippets_bridge.h
diff --git a/chrome/browser/android/ntp/ntp_snippets_bridge.h b/chrome/browser/android/ntp/ntp_snippets_bridge.h
index e5332b84e9b5cceab2566e308c16127abcaad906..4a0346b192a250c04fa7b2111e0fc6b3567143e9 100644
--- a/chrome/browser/android/ntp/ntp_snippets_bridge.h
+++ b/chrome/browser/android/ntp/ntp_snippets_bridge.h
@@ -54,13 +54,15 @@ class NTPSnippetsBridge
void FetchSuggestionImage(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jstring>& suggestion_id,
+ jint category,
+ const base::android::JavaParamRef<jstring>& within_category_id,
const base::android::JavaParamRef<jobject>& j_callback);
void DismissSuggestion(
JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
- const base::android::JavaParamRef<jstring>& suggestion_id);
+ jint category,
+ const base::android::JavaParamRef<jstring>& within_category_id);
void DismissCategory(JNIEnv* env,
const base::android::JavaParamRef<jobject>& obj,
@@ -124,8 +126,8 @@ class NTPSnippetsBridge
void OnCategoryStatusChanged(
ntp_snippets::Category category,
ntp_snippets::CategoryStatus new_status) override;
- void OnSuggestionInvalidated(ntp_snippets::Category category,
- const std::string& suggestion_id) override;
+ void OnSuggestionInvalidated(
+ const ntp_snippets::ContentSuggestion::ID& suggestion_id) override;
void ContentSuggestionsServiceShutdown() override;
void OnImageFetched(base::android::ScopedJavaGlobalRef<jobject> callback,

Powered by Google App Engine
This is Rietveld 408576698