chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java - Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

Issue 2377663002: [NTP Snippets] Introduce ContentSuggestion::ID (Closed)

Patch Set: . Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/SuggestionsSection.java » ('j') | components/ntp_snippets/ntp_snippets_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

index d9f4470a5eb28af3edd95a0305c919af43bca071..532f5450767c0edbf24ca2bf574615d6cbbd87f7 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageRecyclerView.java

@@ -416,7 +416,7 @@ public class NewTabPageRecyclerView extends RecyclerView {

public void dismissItemWithAnimation(SnippetArticle suggestion) {

// We need to recompute the position, as it might have changed.

- final int position = getNewTabPageAdapter().getSuggestionPosition(suggestion.mId);

+ final int position = getNewTabPageAdapter().getSuggestionPosition(suggestion);

if (position == RecyclerView.NO_POSITION) {

// The item does not exist anymore, so ignore.

return;