|
|
Chromium Code Reviews
Descriptioncorrected undefined behaviour when ptr is NULL in HeapFree.
caught one place where free(NULL) happens:
icu_56::Locale::init(const char * localeID, char canonicalize)
BUG=
Committed: https://crrev.com/dbbfbea5210e41762b1c487b1a997a2e860b7bc3
Cr-Commit-Position: refs/heads/master@{#421494}
Patch Set 1 #Patch Set 2 : added myself to authors file #Messages
Total messages: 22 (10 generated)
Description was changed from ========== corrected undefined behaviour when ptr is NULL in HeapFree BUG= ========== to ========== corrected undefined behaviour when ptr is NULL in HeapFree. caught one place where free(NULL) happens: icu_56::Locale::init(const char * localeID, char canonicalize) BUG= ==========
kruntuid@gmail.com changed reviewers: + siggi@chromium.org
lgtm - thanks! "size" was a little misleading there as param name, thanks for fixing that too.
The CQ bit was checked by kruntuid@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
The author kruntuid@gmail.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign and manage CLA.
The CQ bit was checked by kruntuid@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
kruntuid@gmail.com changed reviewers: + wfh@chromium.org
updated review
On 2016/09/27 15:01:36, kruntuid wrote: > updated review still lgtm
still lgtm from me too.
The CQ bit was checked by kruntuid@gmail.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== corrected undefined behaviour when ptr is NULL in HeapFree. caught one place where free(NULL) happens: icu_56::Locale::init(const char * localeID, char canonicalize) BUG= ========== to ========== corrected undefined behaviour when ptr is NULL in HeapFree. caught one place where free(NULL) happens: icu_56::Locale::init(const char * localeID, char canonicalize) BUG= ==========
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== corrected undefined behaviour when ptr is NULL in HeapFree. caught one place where free(NULL) happens: icu_56::Locale::init(const char * localeID, char canonicalize) BUG= ========== to ========== corrected undefined behaviour when ptr is NULL in HeapFree. caught one place where free(NULL) happens: icu_56::Locale::init(const char * localeID, char canonicalize) BUG= Committed: https://crrev.com/dbbfbea5210e41762b1c487b1a997a2e860b7bc3 Cr-Commit-Position: refs/heads/master@{#421494} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/dbbfbea5210e41762b1c487b1a997a2e860b7bc3 Cr-Commit-Position: refs/heads/master@{#421494} |
