Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(563)

Issue 2377633002: corrected undefined behaviour when ptr is NULL in HeapFree (Closed)

Created:
4 years, 2 months ago by kruntuid
Modified:
4 years, 2 months ago
CC:
chromium-reviews, wfh+watch_chromium.org, Dai Mikurube (NOT FULLTIME)
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

corrected undefined behaviour when ptr is NULL in HeapFree. caught one place where free(NULL) happens: icu_56::Locale::init(const char * localeID, char canonicalize) BUG= Committed: https://crrev.com/dbbfbea5210e41762b1c487b1a997a2e860b7bc3 Cr-Commit-Position: refs/heads/master@{#421494}

Patch Set 1 #

Patch Set 2 : added myself to authors file #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -2 lines) Patch
M AUTHORS View 1 1 chunk +1 line, -0 lines 0 comments Download
M base/allocator/winheap_stubs_win.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
kruntuid
4 years, 2 months ago (2016-09-27 13:27:54 UTC) #3
Sigurður Ásgeirsson
lgtm - thanks! "size" was a little misleading there as param name, thanks for fixing ...
4 years, 2 months ago (2016-09-27 14:24:46 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377633002/1
4 years, 2 months ago (2016-09-27 14:34:42 UTC) #6
commit-bot: I haz the power
The author kruntuid@gmail.com has not signed Google Contributor License Agreement. Please visit https://cla.developers.google.com to sign ...
4 years, 2 months ago (2016-09-27 14:34:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377633002/1
4 years, 2 months ago (2016-09-27 14:38:32 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/267675)
4 years, 2 months ago (2016-09-27 14:47:25 UTC) #12
kruntuid
updated review
4 years, 2 months ago (2016-09-27 15:01:36 UTC) #14
Sigurður Ásgeirsson
On 2016/09/27 15:01:36, kruntuid wrote: > updated review still lgtm
4 years, 2 months ago (2016-09-27 15:09:17 UTC) #15
Will Harris
still lgtm from me too.
4 years, 2 months ago (2016-09-27 21:20:51 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377633002/20001
4 years, 2 months ago (2016-09-28 10:25:25 UTC) #18
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 2 months ago (2016-09-28 11:05:44 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 11:07:39 UTC) #22
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dbbfbea5210e41762b1c487b1a997a2e860b7bc3
Cr-Commit-Position: refs/heads/master@{#421494}

Powered by Google App Engine
This is Rietveld 408576698