Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 2377623002: Handle constructor invocation, is, as, throw, for-in and (a)sync(*) in kernel_impact (Closed)

Created:
4 years, 2 months ago by Johnni Winther
Modified:
4 years, 2 months ago
Reviewers:
Harry Terkelsen
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle constructor invocation, is, as, throw, for-in and (a)sync(*) in kernel_impact R=het@google.com Committed: https://github.com/dart-lang/sdk/commit/ee42a0524a48a7fdf06d2ef7040f95d974ffdd8d

Patch Set 1 #

Patch Set 2 : Remove test line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+148 lines, -19 lines) Patch
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 5 chunks +76 lines, -16 lines 0 comments Download
M tests/compiler/dart2js/kernel/impact_test.dart View 1 6 chunks +68 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
4 years, 2 months ago (2016-09-27 13:17:41 UTC) #2
Harry Terkelsen
lgtm
4 years, 2 months ago (2016-09-27 17:08:51 UTC) #3
Johnni Winther
4 years, 2 months ago (2016-09-30 07:58:18 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
ee42a0524a48a7fdf06d2ef7040f95d974ffdd8d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698