Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(862)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2377613002: Remove cancelMediaDevicesRequest dead code. (Closed)

Created:
4 years, 2 months ago by Guido Urdaneta
Modified:
4 years, 2 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, einbinder+watch-test-runner_chromium.org, eric.carlson_apple.com, feature-media-reviews_chromium.org, haraken, jam, jochen+watch_chromium.org, kinuko+watch, mcasas+watch+mediastream_chromium.org, mcasas+watch+vc_chromium.org, miu+watch_chromium.org, mlamouri+watch-content_chromium.org, mlamouri+watch-blink_chromium.org, mlamouri+watch-test-runner_chromium.org, posciak+watch_chromium.org, Srirama, tommyw+watchlist_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove cancelMediaDevicesRequest dead code. BUG=650605 Committed: https://crrev.com/569445a9fd1759f7781e055c4f04173c31fa3f1a Cr-Commit-Position: refs/heads/master@{#421593}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -35 lines) Patch
M components/test_runner/mock_web_user_media_client.h View 1 chunk +0 lines, -1 line 0 comments Download
M components/test_runner/mock_web_user_media_client.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M content/renderer/media/user_media_client_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M content/renderer/media/user_media_client_impl.cc View 1 chunk +0 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaClient.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/mediastream/UserMediaController.h View 2 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/web/UserMediaClientImpl.cpp View 1 chunk +0 lines, -6 lines 0 comments Download
M third_party/WebKit/public/web/WebUserMediaClient.h View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 13 (7 generated)
Guido Urdaneta
tommi@chromium.org: Please review changes in content/renderer/media mkwst@chromium.org: Please review changes in components/test_runner and WebKit
4 years, 2 months ago (2016-09-27 11:45:26 UTC) #2
tommi (sloooow) - chröme
lgtm
4 years, 2 months ago (2016-09-27 11:58:52 UTC) #5
Mike West
Removing code LGTM! \o/
4 years, 2 months ago (2016-09-28 11:27:28 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377613002/1
4 years, 2 months ago (2016-09-28 17:29:35 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-28 18:57:30 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-28 19:01:51 UTC) #13
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/569445a9fd1759f7781e055c4f04173c31fa3f1a
Cr-Commit-Position: refs/heads/master@{#421593}

Powered by Google App Engine
This is Rietveld 408576698