chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc - Issue 2377603002: Disable ServiceWorker when JS is disabled

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

Issue 2377603002: Disable ServiceWorker when JS is disabled (Closed)

Patch Set: Updated comments, removed the mock headers and renamed the function Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/content_settings/tab_specific_content_settings_unittest.cc ('k') | content/browser/service_worker/service_worker_dispatcher_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

diff --git a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

index ed0b57ae9606a83a515ce25a4871662a858a4abe..dc5ab231efa1b6edb9268bbd592f0e3a689b6b84 100644

--- a/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

+++ b/chrome/browser/ui/content_settings/content_setting_bubble_model_unittest.cc

@@ -104,7 +104,7 @@ TEST_F(ContentSettingBubbleModelTest, Cookies) {

EXPECT_TRUE(bubble_content.custom_link_enabled);

EXPECT_FALSE(bubble_content.manage_text.empty());

- content_settings->ClearCookieSpecificContentSettings();

+ content_settings->ClearNavigationRelatedContentSettings();

content_settings->OnContentAllowed(CONTENT_SETTINGS_TYPE_COOKIES);

content_setting_bubble_model.reset(

ContentSettingBubbleModel::CreateContentSettingBubbleModel(

@@ -744,7 +744,8 @@ TEST_F(ContentSettingBubbleModelTest, PepperBroker) {

EXPECT_FALSE(bubble_content.custom_link_enabled);

EXPECT_FALSE(bubble_content.manage_text.empty());

- content_settings->ClearBlockedContentSettingsExceptForCookies();

+ content_settings

+ ->ClearContentSettingsExceptForNavigationRelatedSettings();

content_settings->OnContentAllowed(CONTENT_SETTINGS_TYPE_PPAPI_BROKER);

content_setting_bubble_model.reset(

ContentSettingBubbleModel::CreateContentSettingBubbleModel(