Disable ServiceWorker when JS is disabled

chrome/browser/chrome_service_worker_browsertest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // This file tests that Service Workers (a Content feature) work in the Chromium
 // embedder.
 
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/run_loop.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/test/histogram_tester.h"
 #include "build/build_config.h"
 #include "chrome/browser/chrome_notification_types.h"
+#include "chrome/browser/content_settings/host_content_settings_map_factory.h"
+#include "chrome/browser/content_settings/tab_specific_content_settings.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_window.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/test/base/in_process_browser_test.h"
 #include "chrome/test/base/ui_test_utils.h"
+#include "components/content_settings/core/browser/host_content_settings_map.h"
 #include "content/public/browser/browser_context.h"
 #include "content/public/browser/render_frame_host.h"
 #include "content/public/browser/service_worker_context.h"
 #include "content/public/browser/storage_partition.h"
 #include "content/public/browser/web_contents.h"
 #include "content/public/common/content_features.h"
 #include "content/public/common/content_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "net/test/embedded_test_server/embedded_test_server.h"
 #include "ppapi/shared_impl/ppapi_switches.h"
 
 namespace {
 
 class ChromeServiceWorkerTest : public InProcessBrowserTest {
  protected:
   ChromeServiceWorkerTest() {
     EXPECT_TRUE(service_worker_dir_.CreateUniqueTempDir());
+    EXPECT_TRUE(base::CreateDirectoryAndGetError(
+        service_worker_dir_.GetPath().Append("scope"), nullptr));
   }
   ~ChromeServiceWorkerTest() override {}
 
   void WriteFile(const base::FilePath::StringType& filename,
                  base::StringPiece contents) {
     EXPECT_EQ(base::checked_cast<int>(contents.size()),
               base::WriteFile(service_worker_dir_.GetPath().Append(filename),
                               contents.data(), contents.size()));
   }
 
@@ skipping 66 matching lines @@
                                embedded_test_server()->GetURL("/test.html"));
 
   content::WindowedNotificationObserver observer(
       chrome::NOTIFICATION_BROWSER_CLOSED, content::Source<Browser>(incognito));
   incognito->window()->Close();
   observer.Wait();
 
   // Test passes if we don't crash.
 }
 
+IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,
+                       FailRegisterServiceWorkerWhenJSDisabled) {
+  WriteFile(FILE_PATH_LITERAL("service_worker.js"), "");
+  WriteFile(FILE_PATH_LITERAL("service_worker.js.mock-http-headers"),
+            "HTTP/1.1 200 OK\nContent-Type: text/javascript");
+
+  embedded_test_server()->ServeFilesFromDirectory(
+      service_worker_dir_.GetPath());
+  ASSERT_TRUE(embedded_test_server()->Start());
+
+  HostContentSettingsMapFactory::GetForProfile(browser()->profile())
+      ->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_JAVASCRIPT,
+                                 CONTENT_SETTING_BLOCK);
+
+  content::ServiceWorkerContext* sw_context =
+      content::BrowserContext::GetDefaultStoragePartition(browser()->profile())
+          ->GetServiceWorkerContext();
+
+  base::RunLoop run_loop;
+  sw_context->RegisterServiceWorker(
+      embedded_test_server()->GetURL("/"),
+      embedded_test_server()->GetURL("/service_worker.js"),
+      base::Bind(&ExpectResultAndRun, false, run_loop.QuitClosure()));
+  run_loop.Run();
+}
+
+IN_PROC_BROWSER_TEST_F(ChromeServiceWorkerTest,
+                       FallbackMainResourceRequestWhenJSDisabled) {
+  WriteFile(
+      FILE_PATH_LITERAL("sw.js"),
+      "self.onfetch = function(e) {"
+      "  e.respondWith(new Response('<title>Fail</title>',"
+      "                             {headers: {'Content-Type': 'text/html'}}));"
+      "};");
+  WriteFile(FILE_PATH_LITERAL("scope/done.html"), "<title>Done</title>");
+  WriteFile(
+      FILE_PATH_LITERAL("test.html"),
+      "<script>"
+      "navigator.serviceWorker.register('./sw.js', {scope: './scope/'})"
+      "  .then(function(reg) {"
+      "      reg.addEventListener('updatefound', function() {"
+      "          var worker = reg.installing;"
+      "          worker.addEventListener('statechange', function() {"
+      "              if (worker.state == 'activated')"
+      "                document.title = 'READY';"
+      "            });"
+      "        });"
+      "    });"
+      "</script>");
+  embedded_test_server()->ServeFilesFromDirectory(
+      service_worker_dir_.GetPath());
+  ASSERT_TRUE(embedded_test_server()->Start());
+
+  const base::string16 expected_title1 = base::ASCIIToUTF16("READY");
+  content::TitleWatcher title_watcher1(
+      browser()->tab_strip_model()->GetActiveWebContents(), expected_title1);
+  ui_test_utils::NavigateToURL(browser(),
+                               embedded_test_server()->GetURL("/test.html"));
+  EXPECT_EQ(expected_title1, title_watcher1.WaitAndGetTitle());
+
+  content::ServiceWorkerContext* sw_context =
+      content::BrowserContext::GetDefaultStoragePartition(browser()->profile())
+          ->GetServiceWorkerContext();
+  sw_context->StopAllServiceWorkersForOrigin(
+      embedded_test_server()->base_url());
+
+  HostContentSettingsMapFactory::GetForProfile(browser()->profile())
+      ->SetDefaultContentSetting(CONTENT_SETTINGS_TYPE_JAVASCRIPT,
+                                 CONTENT_SETTING_BLOCK);
+
+  const base::string16 expected_title2 = base::ASCIIToUTF16("Done");
+  content::TitleWatcher title_watcher2(
+      browser()->tab_strip_model()->GetActiveWebContents(), expected_title2);
+  ui_test_utils::NavigateToURL(
+      browser(),
+      embedded_test_server()->GetURL("/scope/done.html"));
+  EXPECT_EQ(expected_title2, title_watcher2.WaitAndGetTitle());

[jochen (gone - plz use gerrit), 2016/09/29 12:15:49]

you could check that the tab's tab_specific_content_settings return true for
IsContentBlocked(CONTENT_SETTINGS_TYPE_JAVASCRIPT) and not before navigating

[shimazu, 2016/10/04 09:21:48]

Done.

+}
+
 class ChromeServiceWorkerFetchTest : public ChromeServiceWorkerTest {
  protected:
   ChromeServiceWorkerFetchTest() {}
   ~ChromeServiceWorkerFetchTest() override {}
 
   void SetUpOnMainThread() override {
     WriteServiceWorkerFetchTestFiles();
     embedded_test_server()->ServeFilesFromDirectory(
         service_worker_dir_.GetPath());
     ASSERT_TRUE(embedded_test_server()->Start());
@@ skipping 460 matching lines @@
   EXPECT_EQ(expected_title2, title_watcher2.WaitAndGetTitle());
 
   // The service worker must be started by a navigation hint.
   histogram_tester_.ExpectBucketCount(
       "ServiceWorker.StartWorker.StatusByPurpose_NAVIGATION_HINT_LINK_MOUSE_"
       "DOWN",
       0 /* SERVICE_WORKER_OK */, 1);
 }
 
 }  // namespace