Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Issue 2377593002: Reland of Preparse functions in the scope that was created when parsing of the function was started (Closed)

Created:
4 years, 2 months ago by Camillo Bruni
Modified:
4 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Preparse functions in the scope that was created when parsing of the function was started (patchset #1 id:1 of https://codereview.chromium.org/2365393002/ ) Reason for revert: Stability thief found, relanding speculative reverts. Original issue's description: > Revert of Preparse functions in the scope that was created when parsing of the function was started (patchset #2 id:20001 of https://codereview.chromium.org/2370713003/ ) > > Reason for revert: > Needed for https://codereview.chromium.org/2373443003/ > > Original issue's description: > > Preparse functions in the scope that was created when parsing of the function was started > > > > This reduces the number of scopes for lazily parsed top-level functions from 3 to 1 > > > > BUG=v8:5209 > > > > Committed: https://crrev.com/9618d095903c604a032b33792c068f4a6169503c > > Cr-Commit-Position: refs/heads/master@{#39725} > > TBR=marja@chromium.org,verwaest@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:5209 > > Committed: https://crrev.com/0cef7100da0b609403c9026fb7307192a898a390 > Cr-Commit-Position: refs/heads/master@{#39729} TBR=marja@chromium.org,verwaest@chromium.org,hablich@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:5209 Committed: https://crrev.com/47f303b66b6333a89f2608585c9dbe0e60d9f674 Cr-Commit-Position: refs/heads/master@{#39756}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M src/ast/scopes.h View 1 chunk +14 lines, -0 lines 0 comments Download
M src/parsing/parser.cc View 4 chunks +14 lines, -29 lines 0 comments Download
M src/parsing/parser-base.h View 2 chunks +7 lines, -2 lines 0 comments Download
M src/parsing/preparser.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/parsing/preparser.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Camillo Bruni
Created Reland of Preparse functions in the scope that was created when parsing of the ...
4 years, 2 months ago (2016-09-27 09:49:03 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2377593002/1
4 years, 2 months ago (2016-09-27 09:49:05 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-27 09:49:30 UTC) #4
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 09:49:50 UTC) #6
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/47f303b66b6333a89f2608585c9dbe0e60d9f674
Cr-Commit-Position: refs/heads/master@{#39756}

Powered by Google App Engine
This is Rietveld 408576698