Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2377583002:
Enable per thread heap on DedicatedWorker (Closed)
|
Created:
4 years, 2 months ago by keishi Modified:
4 years, 2 months ago CC:
chromium-reviews, shimazu+worker_chromium.org, falken, kinuko+worker_chromium.org, blink-reviews, horo+watch_chromium.org, blink-worker-reviews_chromium.org Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionEnable per thread heap on DedicatedWorker
blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc
BUG=591606
Committed: https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025
Cr-Commit-Position: refs/heads/master@{#421456}
Patch Set 1 #
Messages
Total messages: 21 (14 generated)
The CQ bit was checked by keishi@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Enable pth on DedicatedWorker BUG= ========== to ========== Enable per thread heap on DedicatedWorker BUG=591606 ==========
keishi@chromium.org changed reviewers: + haraken@chromium.org, oilpan-reviews@chromium.org
PTAL Per thread heap has been enabled on the CompositorWorker for more than a week. And I confirmed that CQ passes for enabling per thread heap on all workers. DedicatedWorker: this SharedWorker: https://codereview.chromium.org/2374693002/ ServiceWorker: https://codereview.chromium.org/2369013004/
LGTM Add a link to the Intent thread to the CL description.
Description was changed from ========== Enable per thread heap on DedicatedWorker BUG=591606 ========== to ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 ==========
The CQ bit was checked by keishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 ========== to ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 ========== to ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 Committed: https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025 Cr-Commit-Position: refs/heads/master@{#421456} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025 Cr-Commit-Position: refs/heads/master@{#421456}
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2392233002/ by keishi@chromium.org. The reason for reverting is: Caused crashes crbug.com/652058 crbug.com/651702 crbug.com/652001 crbug.com/652264 crbug.com/652183 crbug.com/652556.
Message was sent while issue was closed.
Description was changed from ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 Committed: https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025 Cr-Commit-Position: refs/heads/master@{#421456} ========== to ========== [reland] Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 Committed: https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025 Cr-Commit-Position: refs/heads/master@{#421456} ==========
The CQ bit was checked by keishi@chromium.org
The CQ bit was unchecked by keishi@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [reland] Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 Committed: https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025 Cr-Commit-Position: refs/heads/master@{#421456} ========== to ========== Enable per thread heap on DedicatedWorker blink-dev PSA email: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/wROZOp-YKSc BUG=591606 Committed: https://crrev.com/d1aef67937aa7bcb5fb79a18fbf2759de21a3025 Cr-Commit-Position: refs/heads/master@{#421456} ========== |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
