chrome/browser/notifications/platform_notification_service_impl.cc - Issue 2377553003: Add ShouldDisplayOverFullscreen support to web notifications.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/platform_notification_service_impl.cc

Issue 2377553003: Add ShouldDisplayOverFullscreen support to web notifications. (Closed)

Patch Set: Removing previously committed changes from cl (via git pull) Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/platform_notification_service_impl.cc

diff --git a/chrome/browser/notifications/platform_notification_service_impl.cc b/chrome/browser/notifications/platform_notification_service_impl.cc

index 7b1472ac7d62e6cf12000c86bb5b7f3d667b9a75..c8bfae36ad8e760c9f72fcb48d7fd960de4e92f5 100644

--- a/chrome/browser/notifications/platform_notification_service_impl.cc

+++ b/chrome/browser/notifications/platform_notification_service_impl.cc

@@ -287,7 +287,7 @@ void PlatformNotificationServiceImpl::DisplayNotification(

DCHECK_EQ(0u, notification_resources.action_icons.size());

NotificationObjectProxy* proxy = new NotificationObjectProxy(

- browser_context, notification_id, std::move(delegate));

+ browser_context, notification_id, origin, std::move(delegate));

Notification notification = CreateNotificationFromData(

profile, GURL() /* service_worker_scope */, origin, notification_data,

notification_resources, proxy);