Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(997)

Unified Diff: chrome/browser/notifications/persistent_notification_delegate.h

Issue 2377553003: Add ShouldDisplayOverFullscreen support to web notifications. (Closed)
Patch Set: Final formatting fixes Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/persistent_notification_delegate.h
diff --git a/chrome/browser/notifications/persistent_notification_delegate.h b/chrome/browser/notifications/persistent_notification_delegate.h
index 3fc29a02b7ef9b22fccfe63c37aae17432e12e6a..932dc5fe1f9f49cc88bc78da19a40906b70daa3e 100644
--- a/chrome/browser/notifications/persistent_notification_delegate.h
+++ b/chrome/browser/notifications/persistent_notification_delegate.h
@@ -8,8 +8,9 @@
#include <string>
#include "base/macros.h"
-#include "chrome/browser/notifications/notification_delegate.h"
-#include "url/gurl.h"
+#include "chrome/browser/notifications/web_notification_delegate.h"
+
+class GURL;
namespace content {
class BrowserContext;
@@ -18,7 +19,7 @@ class BrowserContext;
// Delegate responsible for listening to the click event on persistent
// notifications, to forward them to the PlatformNotificationService so that
// JavaScript events can be fired on the associated Service Worker.
-class PersistentNotificationDelegate : public NotificationDelegate {
+class PersistentNotificationDelegate : public WebNotificationDelegate {
public:
PersistentNotificationDelegate(content::BrowserContext* browser_context,
const std::string& notification_id,
@@ -30,18 +31,11 @@ class PersistentNotificationDelegate : public NotificationDelegate {
void Close(bool by_user) override;
void Click() override;
void ButtonClick(int button_index) override;
- void SettingsClick() override;
- bool ShouldDisplaySettingsButton() override;
-
- std::string id() const override;
protected:
~PersistentNotificationDelegate() override;
private:
- content::BrowserContext* browser_context_;
- std::string notification_id_;
- GURL origin_;
int notification_settings_index_;
DISALLOW_COPY_AND_ASSIGN(PersistentNotificationDelegate);

Powered by Google App Engine
This is Rietveld 408576698