Add ShouldDisplayOverFullscreen support to web notifications.

chrome/browser/notifications/web_notification_delegate.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
+#define CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_
+
+#include <string>
+
+#include "base/macros.h"
+#include "chrome/browser/notifications/notification_delegate.h"
+#include "url/gurl.h"
+
+namespace content {
+class BrowserContext;
+}
+
+// Base class for the PersistentNotificationDelegate and the
+// NotificationObjectProxy. All common functionality for displaying web
+// notifications is found here.

[Peter Beverloo, 2016/09/27 17:17:37]

nit: This may feel rather counter-intuitive today, but would you mind adding the
following TODO since we'd like to drop the delegates for web notifications
altogether?

// TODO(peter, crbug.com/596161): Migrate this functionality offered by the
// delegate to the NotificationDisplayService.

[bmalcolm, 2016/09/27 20:34:36]

Done.

+class WebNotificationDelegate : public NotificationDelegate {
+ public:
+  WebNotificationDelegate(content::BrowserContext* browser_context,

[Peter Beverloo, 2016/09/27 17:17:37]

nit: maybe make this protected too to avoid anyone instantiating this class by
accident?

[bmalcolm, 2016/09/27 20:34:36]

Done.

+                          const std::string& notification_id,
+                          const GURL& origin);
+

[Peter Beverloo, 2016/09/27 17:17:37]

micro nit:

// NotificationDelegate implementation.

[bmalcolm, 2016/09/27 20:34:36]

Done.

+  std::string id() const override;
+  void SettingsClick() override;
+  bool ShouldDisplaySettingsButton() override;
+  bool ShouldDisplayOverFullscreen() const override;
+
+ protected:
+  ~WebNotificationDelegate() override;
+
+  content::BrowserContext* browser_context() { return browser_context_; }
+  const GURL& origin() { return origin_; }
+
+ private:
+  content::BrowserContext* browser_context_;
+  std::string notification_id_;
+  GURL origin_;

[Peter Beverloo, 2016/09/27 17:17:37]

nit: DISALLOW_COPY_AND_ASSIGN(WebNotificationDelegate);

[bmalcolm, 2016/09/27 20:34:36]

Done.

+};
+
+
+#endif  // CHROME_BROWSER_NOTIFICATIONS_WEB_NOTIFICATION_DELEGATE_H_